feat: Add Coulomb friction/cohesion per cell fields#4067
Open
npillardou wants to merge 25 commits into
Open
Conversation
npillardou
requested review from
OmarDuran,
dkachuma,
herve-gross and
jhuang2601
as code owners
npillardou
added
flag: requires rebaseline
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jhuang2601
approved these changes
May 29, 2026
| TestDeck( | ||
| name="ALM_inclinedFault_ESG_friction_cohesion_smoke", | ||
| description='PoroElastic ALM inclined fault with cohesion/frictionCoeff provided in mesh (per cell variation)', | ||
| partitions=((1, 1, 1),), |
Contributor
There was a problem hiding this comment.
Please add MPI run
Suggested change
| partitions=((1, 1, 1),), | |
| partitions=((1, 1, 1), (2, 2, 1)), |
jafranc
requested changes
Jun 2, 2026
Contributor
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
Nice step towards full heterogeneity in parameters.
Though please minimize interfaces changes.
|
|
||
| real64 const cohesion = hasCoulombParams ? frictionLaw.getReference< real64 >( CoulombFriction::viewKeyStruct::cohesionString() ) : 0.0; | ||
| real64 const frictionCoefficient = hasCoulombParams ? frictionLaw.getReference< real64 >( CoulombFriction::viewKeyStruct::frictionCoefficientString() ) : 0.0; | ||
| arrayView1d< real64 const > cohesion; |
Contributor
There was a problem hiding this comment.
I would zero-ed cohesion and frictionCoefficient and revise the logic for !hasCoulombParams case (error ? warning ?)
| arrayView1d< real64 const > frictionCoefficient; | ||
| if( hasCoulombParams ) | ||
| { | ||
| cohesion = frictionLaw.getWrapper< array1d< real64 > >( fields::contact::cohesion::key() ).reference().toViewConst(); |
Contributor
There was a problem hiding this comment.
getField< fields::contact::cohesion >() ?
| { | ||
|
|
||
| GEOS_UNUSED_VAR( tractionVector ); | ||
| GEOS_UNUSED_VAR( k, tractionVector ); |
Contributor
There was a problem hiding this comment.
please don't change signature for unused new params !
| { | ||
| integer const originalFractureState = fractureState[kfe]; | ||
| frictionWrapper.updateFractureState( dispJump[kfe], traction[kfe], fractureState[kfe] ); | ||
| frictionWrapper.updateFractureState( kfe, dispJump[kfe], traction[kfe], fractureState[kfe] ); |
Contributor
There was a problem hiding this comment.
please don't change signature to introduce unused parameters ! It just increases complexity with no reward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following features:
At the moment this feature is only available for external splitting with mesh_doctor workflow. It appears more complicated to deal with internal surface generator. This will give place to another PR.