build: GitHub workflows to publish the React and Angular SDKs to npmjs are failing#197
Draft
mrudatsprint wants to merge 3 commits into
Draft
build: GitHub workflows to publish the React and Angular SDKs to npmjs are failing#197mrudatsprint wants to merge 3 commits into
mrudatsprint wants to merge 3 commits into
Conversation
mrudatsprint
changed the title
mrudatsprint
changed the title
…peScript to use vitest's bundled vite types. It was a double-slash or comment. Also, don't pull in vite.config.ts in tsconfig.json as this was pulling the vite config into type checking.
mrudatsprint
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes npm publish workflow failures for the React and Angular SDK packages by ensuring required package metadata is present for npm provenance and by resolving a React build/typecheck issue introduced during the Angular 22 upgrade.
Changes:
- React: ensure Vitest types are correctly referenced in
vite.config.tsand avoid typechecking the Vite config viatsconfig.json. - Angular: add
repositorymetadata (plus standardauthor,license,bugs) to satisfy npm provenance/source requirements.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/sdk-react/vite.config.ts |
Uses a proper triple-slash reference so the config can typecheck with Vitest types. |
packages/sdk-react/tsconfig.json |
Stops including vite.config.ts in tsc compilation to prevent config-related build/typecheck failures. |
packages/sdk-angular/projects/fusionauth-angular-sdk/package.json |
Adds repository.url (and related metadata) required for npm’s signed provenance publication. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The GitHub workflows to publish the React and Angular SDKs to npmjs are failing.
Test:
The React and Angular SDKs have now been published to npmjs.