Add support for marking nodes as unavailable.#14
Open
adamvaughan wants to merge 1 commit intoFrameio:masterfrom
Open
Add support for marking nodes as unavailable.#14adamvaughan wants to merge 1 commit intoFrameio:masterfrom
adamvaughan wants to merge 1 commit intoFrameio:masterfrom
Conversation
Marking a node as unavailable will temporarily remove it from the cluster and add it back after a delay. If the node continues to fail the delay before adding it back will increase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using memcachir we've noticed occasions where a node in our Elasticache cluster will become unavailable, but still be returned in the health check, causing errors when trying to send requests to it. This change would allow us to handle those errors and mark the node as temporarily unavailable.
With these changes, unavailable nodes are temporarily removed from the cluster and excluded from health check results until a timeout expires. After a configurable delay they are added back where they can be retried. If a node continues to fail, the delay before adding it back in will be increased.