Skip to content

Added alarm groups - #473

Open
tristanlifn wants to merge 23 commits into
FossifyOrg:mainfrom
tristanlifn:main
Open

tristanlifn wants to merge 23 commits into
FossifyOrg:mainfrom
tristanlifn:main

Conversation

@tristanlifn

@tristanlifn tristanlifn commented Jul 18, 2026

Copy link
Copy Markdown

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

This feature addes groups to alarms.

  • Create groups: select one or more alarms and click the folder icon in the top bar, create a new group by enering a name
  • Delete groups: Enter a group and press the three dots, press Delete group. This will remove all the alarms from the group, not delete them
  • Change group: Select one or more alarms, click the group icon and select any group.
  • Rename group: Enter a group and click on the name. change the name and save.
  • remove from group: Select one or more alarms, click the group icon and select the None group.
  • Export: Adds support to exporting alarms, groups, and timers
  • Import: Adds support to import groups, and restores alarms to the right group

Tests performed

Thrugh none of my testing have i noticed any performance changes.

Before & after preview

Before:
ignoreImageMinify

After:
ignoreImageMinify

ignoreImageMinify ignoreImageMinify

Closes the following issue(s)

Sorry. i know that it says only work on accepted features. but i realy want this. hope its okay!
But this PR needs PR #365 in commons to be fixed before this will work, as it relies on that change.

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (both).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • I understand every change in this pull request.

Note. there was a problem with my git vonfig, so some of the commits says they were authored by "wit00", this is not the case and i have made all commits by myself

wit00 and others added 13 commits July 17, 2026 14:17
…h translations from DeepL. Note: translations might be wrong, and multiple languages that have other translations have no translations because of missing support from DeepL
…e are more than zero groups. Removed hack fix for "getSelectedDaysString". Changed group toggle off when no alarms are on, not when all are on. changed commons version to 6.1.7 (see [PR FossifyOrg#365](FossifyOrg/commons#365))
…mporting backup. alarms get added to a group that does not exist
@tristanlifn
tristanlifn requested a review from naveensingh as a code owner July 18, 2026 11:21
@tristanlifn

Copy link
Copy Markdown
Author

I want to add regarding failed tests. The detekt errors/warnings are not critical, i can still build and run it. Regarding the other build errors, they are from /home/runner/.m2/repository/org/fossify/commons/6.1.7/commons-6.1.7.pom, not a file i have touched. It should work fine if you test it.

Fixed "None" group showing when selecting alarms with no group
…alarm would have gone oof, allowing you to skip 1 alarm run.

for groupes it will reenable all alarms after the alarm with the longest until time would have gone off, the reenables all the alarms in the group.
and bumped version name to 1.8.0 and version code to 12
updated to latest fossify clock commit
fixed bug where if an alarm in a group had gone off, then you pressed reenable tomorrow, the group would fist reenable the day after tomorrow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants