Skip to content

refactor: rename register symbol ω → φ#9

Merged
tomusdrw merged 1 commit intomainfrom
td-omega-to-phi-rename
Apr 16, 2026
Merged

refactor: rename register symbol ω → φ#9
tomusdrw merged 1 commit intomainfrom
td-omega-to-phi-rename

Conversation

@tomusdrw
Copy link
Copy Markdown
Member

Summary

  • Rename PVM register symbol from ω (omega) to φ (phi) across the entire codebase to align with the latest Gray Paper revision
  • Updates all user-facing labels, trace display, divergence details, host call descriptions, and comments
  • Adds sprint-49 spec documenting the change

Changed areas

  • Register labels (RegisterRow.tsx): φ0: through φ12:
  • Disassembly (useDisassembly.ts): regName() returns φN
  • Trace display (trace-display.ts): φ7 = ... and φN ← ...
  • Divergence details (useDivergenceCheck.ts): φN: prefix
  • Host call UI (HostCallTab.tsx, GasHostCall.tsx): φ₇ ← output preview
  • Comments/docs: all host call handlers, fetch codec, storage utils, orchestrator

Test plan

  • All 683 unit tests pass
  • Build succeeds
  • Lint passes
  • grep -r 'ω' --include='*.ts' --include='*.tsx' apps/ packages/ returns no results

🤖 Generated with Claude Code

Align with latest Gray Paper revision which changed the PVM register
notation. Updates all user-facing labels, trace display, divergence
details, host call descriptions, and supporting comments/tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 16, 2026

Deploy Preview for pvm-debugger ready!

Name Link
🔨 Latest commit c9b0265
🔍 Latest deploy log https://app.netlify.com/projects/pvm-debugger/deploys/69e0a1cf9e67980008ef242d
😎 Deploy Preview https://deploy-preview-9--pvm-debugger.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

📝 Walkthrough

Walkthrough

This diff replaces omega (ω) register notation with phi (φ) notation throughout the web application and related packages, updating UI labels, test expectations, inline documentation, comments, and supporting utility functions consistently across components, hooks, and libraries.

Changes

Cohort / File(s) Summary
E2E Integration Tests
apps/web/e2e/integration-smoke.spec.ts, apps/web/e2e/sprint-03-instructions.spec.ts, apps/web/e2e/sprint-04-registers.spec.ts, apps/web/e2e/sprint-28-asm-raw-popover.spec.ts
Updated test descriptions, search logic, assertions, and variable names to expect φ notation instead of ω when validating register display and naming in various UI states.
Register Display Components
apps/web/src/components/debugger/RegisterRow.tsx, apps/web/src/components/debugger/RegistersPanel.test.tsx
Updated rendered register label prefix from ω{index}: to φ{index}: in the component and adjusted test comments to reflect the new naming convention.
Trace Display
apps/web/src/components/drawer/trace-display.ts, apps/web/src/components/drawer/trace-display.test.ts
Changed gas/register symbol prefix in trace formatting from ω to φ for ecalli header lines and register write lines; updated corresponding test assertions.
Host Call Components
apps/web/src/components/drawer/HostCallTab.tsx, apps/web/src/components/drawer/hostcalls/GasHostCall.tsx, apps/web/src/components/drawer/hostcalls/LogHostCall.tsx, apps/web/src/components/drawer/hostcalls/StorageHostCall.tsx, apps/web/src/components/drawer/hostcalls/host-call-registers.ts
Updated UI labels and inline documentation for register references from ω₇, ω7–ω11, ω₇..ω₁₂ to corresponding φ variants; updated JSDoc for OutputRegisterMeta.
Disassembly Hook
apps/web/src/hooks/useDisassembly.ts, apps/web/src/hooks/useDisassembly.test.tsx
Updated regName() function to return φ${index} instead of ω${index} and modified test expectations and docstring comments to reflect phi notation for register arguments.
Divergence Check Hook
apps/web/src/hooks/useDivergenceCheck.ts, apps/web/src/hooks/useDivergenceCheck.test.tsx
Renamed register divergence field label from ω<i> to φ<i> in generated details tooltip; updated test assertions and label filtering logic to expect φ prefixed labels.
Utilities & Supporting Code
apps/web/src/hooks/useDebuggerActions.ts, apps/web/src/lib/fetch-codec.ts, apps/web/src/lib/fetch-utils.ts, apps/web/src/lib/storage-utils.ts, apps/web/src/lib/storage-utils.test.ts
Updated inline documentation comments and FETCH_KIND_INFO descriptions to replace register symbol references from ω variants to φ variants; no logic changes.
Orchestrator & Specification
packages/orchestrator/src/orchestrator.ts, spec/ui/sprint-49-register-symbol-omega-to-phi.md
Updated inline documentation for captureLogMemoryReads() register mapping notation and added new spec file documenting the completed register symbol rename initiative with verification criteria and commands.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 45.45% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: renaming the register symbol from ω to φ across the codebase, which is the primary objective of this pull request.
Description check ✅ Passed The description is directly related to the changeset, providing a clear summary of the refactor, listing changed areas, and documenting the test plan with passing verification steps.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch td-omega-to-phi-rename

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@spec/ui/sprint-49-register-symbol-omega-to-phi.md`:
- Around line 94-104: The spec file is missing the required "Status:
Implemented" header and the acceptance criteria are ambiguous about
Unicode/search edge-cases; add "Status: Implemented" at the top of the markdown
and expand the Acceptance Criteria bullets to explicitly include (a) verify no
remaining "ω" in any .ts/.tsx source or test files using both literal and
Unicode-normalized searches, (b) confirm editors/CI search tooling handle
composed vs decomposed φ/phi characters, (c) explicit checks for φN notation in
ASM/disassembly, trace host-call headers and register writes (including the φ₇
glyph and φN: divergence prefixes), (d) a verification step that the host-call
output preview shows "φ₇ ←", and (e) a clarification that spec/ historical docs
must remain unchanged; update the ambiguous sentence about not updating spec/
directory to an explicit requirement so implementers and CI know what to verify.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 34b32aaa-fb5a-4ff9-ae9e-3c95a2ef8ebb

📥 Commits

Reviewing files that changed from the base of the PR and between af91e73 and c9b0265.

📒 Files selected for processing (24)
  • apps/web/e2e/integration-smoke.spec.ts
  • apps/web/e2e/sprint-03-instructions.spec.ts
  • apps/web/e2e/sprint-04-registers.spec.ts
  • apps/web/e2e/sprint-28-asm-raw-popover.spec.ts
  • apps/web/src/components/debugger/RegisterRow.tsx
  • apps/web/src/components/debugger/RegistersPanel.test.tsx
  • apps/web/src/components/drawer/HostCallTab.tsx
  • apps/web/src/components/drawer/hostcalls/GasHostCall.tsx
  • apps/web/src/components/drawer/hostcalls/LogHostCall.tsx
  • apps/web/src/components/drawer/hostcalls/StorageHostCall.tsx
  • apps/web/src/components/drawer/hostcalls/host-call-registers.ts
  • apps/web/src/components/drawer/trace-display.test.ts
  • apps/web/src/components/drawer/trace-display.ts
  • apps/web/src/hooks/useDebuggerActions.ts
  • apps/web/src/hooks/useDisassembly.test.tsx
  • apps/web/src/hooks/useDisassembly.ts
  • apps/web/src/hooks/useDivergenceCheck.test.tsx
  • apps/web/src/hooks/useDivergenceCheck.ts
  • apps/web/src/lib/fetch-codec.ts
  • apps/web/src/lib/fetch-utils.ts
  • apps/web/src/lib/storage-utils.test.ts
  • apps/web/src/lib/storage-utils.ts
  • packages/orchestrator/src/orchestrator.ts
  • spec/ui/sprint-49-register-symbol-omega-to-phi.md

Comment thread spec/ui/sprint-49-register-symbol-omega-to-phi.md
@tomusdrw tomusdrw merged commit 8cfa4bd into main Apr 16, 2026
7 checks passed
@tomusdrw tomusdrw deleted the td-omega-to-phi-rename branch April 16, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant