Skip to content

fix: remove path prefix for custom domain#4

Merged
tomusdrw merged 2 commits intomainfrom
td-gh-pages-no-prefix
Apr 9, 2026
Merged

fix: remove path prefix for custom domain#4
tomusdrw merged 2 commits intomainfrom
td-gh-pages-no-prefix

Conversation

@tomusdrw
Copy link
Copy Markdown
Member

@tomusdrw tomusdrw commented Apr 9, 2026

Summary

  • Changes VITE_BASE_PATH from /pvm-debugger/ to / in the GitHub Pages deploy workflow, since a custom domain is now configured

Test plan

  • Verify GitHub Pages deployment serves assets from root path
  • Confirm the custom domain resolves correctly without /pvm-debugger/ prefix

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1cf504c8-dc13-4de9-a449-f9b855b91bc8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The GitHub Actions workflow for the publish-next job was updated to change the Vite build's base path environment variable from /pvm-debugger/ to /. This configuration change affects how the built web app computes its public URL.

Changes

Cohort / File(s) Summary
Build Configuration
.github/workflows/publish-next.yml
Updated VITE_BASE_PATH environment variable from /pvm-debugger/ to / in the web app build step, changing the base URL for Vite compilation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing the path prefix from the deployment configuration for a custom domain.
Description check ✅ Passed The description is directly related to the changeset, explaining why the VITE_BASE_PATH was changed and providing a test plan to verify the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch td-gh-pages-no-prefix

Comment @coderabbitai help to get the list of available commands and usage tips.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@tomusdrw tomusdrw merged commit 710f0ca into main Apr 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant