Skip to content

Fix Paramater Override Bypass #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christopherholland-workday merged 3 commits into from
Feb 6, 2026
Merged

Fix Paramater Override Bypass #5667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55c99c2
Fix Paramater Override Bypass
christopherholland-workday Jan 22, 2026
46a6acd
Update OverrideConfig.jsx
HenryHengZJ Feb 6, 2026
23dd898
Update VectorStoreDialog.jsx
HenryHengZJ Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/nodes/tools/MCP/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ export const validateCommandInjection = (args: string[]): void => {
}

export const validateEnvironmentVariables = (env: Record<string, any>): void => {
const dangerousEnvVars = ['PATH', 'LD_LIBRARY_PATH', 'DYLD_LIBRARY_PATH']
const dangerousEnvVars = ['PATH', 'LD_LIBRARY_PATH', 'DYLD_LIBRARY_PATH', 'NODE_OPTIONS']

for (const [key, value] of Object.entries(env)) {
if (dangerousEnvVars.includes(key)) {
Expand Down
5 changes: 1 addition & 4 deletions packages/server/src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,10 +1189,7 @@ export const replaceInputsWithConfig = (
continue
}
} else {
// Skip if it is an override "files" input, such as pdfFile, txtFile, etc
if (typeof overrideConfig[config] === 'string' && overrideConfig[config].includes('FILE-STORAGE::')) {
// pass
} else if (!isParameterEnabled(flowNodeData.label, config)) {
if (!isParameterEnabled(flowNodeData.label, config)) {
Copy link
Contributor

@HenryHengZJ HenryHengZJ Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for future reference, this is breaking change for users that are using /vector/upsert endpoint.

curl http://localhost:3000/api/v1/vector/upsert/d7002e48-8448-4cb6-b09e-c916f92ac889 \
     -X POST \
     -F "files=@/home/user1/Desktop/example.txt" \
     -H "Content-Type: multipart/form-data"

Previously you don't have to explicitly enable files in the Override Configuration. With this changes, now you do.

// Only proceed if the parameter is enabled
continue
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/ui-component/extended/OverrideConfig.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ const OverrideConfig = ({ dialogProps }) => {
<TooltipWithParser
style={{ mb: 1, mt: 2, marginLeft: 10 }}
title={
'Enable or disable which properties of the flow configuration can be overridden. Refer to the <a href="https://docs.flowiseai.com/using-flowise/api#override-config" target="_blank">documentation</a> for more information.'
'Enable or disable which properties of the flow configuration can be overridden. Refer to the <a href="https://docs.flowiseai.com/using-flowise/prediction#configuration-override" target="_blank">documentation</a> for more information.'
}
/>
</Typography>
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/src/views/vectorstore/VectorStoreDialog.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@ formData.append("openAIApiKey[openAIEmbeddings_0]", "sk-my-openai-2nd-key")`
<a
rel='noreferrer'
target='_blank'
href='https://docs.flowiseai.com/using-flowise/api#override-config'
href='https://docs.flowiseai.com/using-flowise/prediction#configuration-override'
>
here
</a>{' '}
Expand Down