Skip to content

Conversation

@paodb
Copy link
Member

@paodb paodb commented Sep 23, 2025

Close #149.

This PR updates web-component version to 3.9.0, this version adds support for right-click on mobile devices.

Component version was updated accordingly.

Summary by CodeRabbit

  • Chores

    • Bumped addon version to 2.4.0-SNAPSHOT for upcoming release.
    • Upgraded the underlying Google Maps web component to version 3.9.0 across map, marker, point, and polyline components.
  • Bug Fixes

    • Incorporates fixes included in the updated Google Maps web component.
  • Refactor

    • Standardized dependency versions to align components with the latest Google Maps package for improved consistency and compatibility.

This version adds support to enable "Touch-and-Hold" Gesture as Right-Click Equivalent on Mobile Devices.

Close #149
@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025

Walkthrough

Module version updated in pom.xml to 2.4.0-SNAPSHOT. NpmPackage annotation for @flowingcode/google-map bumped from 3.8.2 to 3.9.0 across GoogleMap, GoogleMapMarker, GoogleMapPoint, and GoogleMapPoly classes. No other code or dependency declarations changed.

Changes

Cohort / File(s) Summary of Changes
Module version bump
pom.xml
Updated artifact version: 2.3.0-SNAPSHOT → 2.4.0-SNAPSHOT.
NpmPackage annotation updates
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java, src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java, src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java, src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java
Bumped @NpmPackage value "@flowingcode/google-map" version: 3.8.2 → 3.9.0. No logic changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • javier-godoy
  • mlopezFC

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change — enabling a touch-and-hold gesture as the right-click equivalent on mobile — and directly maps to linked issue #149 and the PR description that upgrades the web-component to add this behavior, so it is clear and specific for scanning history.
Linked Issues Check ✅ Passed The changeset updates the frontend web-component dependency to 3.9.0 (via @NpmPackage annotations) and bumps the module version, and the 3.9.0 release is documented to add mobile right-click support, so this PR implements the linked issue by pulling in the component that detects touch-and-hold and should emit the right-click event; however the Java side only updates dependency versions and does not change event mappings, so this assessment assumes the web-component preserves the existing right-click event contract that GoogleMapMarkerRightClickEvent listens for.
Out of Scope Changes Check ✅ Passed All code changes are limited to NpmPackage annotation version bumps for the google-map web-component and a pom version bump; these modifications are directly related to bringing in the 3.9.0 web-component that provides the requested mobile right-click behavior and no unrelated source-code or logic changes are present.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-149

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pom.xml (1)

7-7: Version bump looks good.

No issues spotted with moving to 2.4.0-SNAPSHOT.

When releasing, remember to update the Directory entry and tag accordingly.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ccceca0 and dfc3700.

📒 Files selected for processing (5)
  • pom.xml (1 hunks)
  • src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java (1 hunks)
  • src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java (1 hunks)
  • src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java (1 hunks)
  • src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java (1 hunks)
🔇 Additional comments (4)
src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoint.java (1)

31-31: NPM package bump to 3.9.0 is OK.

No further changes required here.

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapMarker.java (1)

42-42: NPM package bump to 3.9.0 is OK.

This aligns with the PR goal; event wiring remains compatible.

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMapPoly.java (1)

42-42: NPM package bump to 3.9.0 is OK.

No concerns.

src/main/java/com/flowingcode/vaadin/addons/googlemaps/GoogleMap.java (1)

53-53: Verify long‑press → right‑click works end‑to‑end with v3.9.0.

  • Wrappers declare @flowingcode/google-map v3.9.0: src/main/java/com/flowingcode/vaadin/addons/googlemaps/{GoogleMap.java, GoogleMapMarker.java, GoogleMapPoint.java, GoogleMapPoly.java}. Marker/map right‑click wiring present: @DomEvent("google-map-marker-rightclick") and addEventListener("google-map-rightclick").
  • No public 3.9.0 release or changelog found for the web component; confirm v3.9.0 is published and that the component emits google-map-rightclick / google-map-marker-rightclick on touch‑and‑hold (mobile).

Optional: expose configurable long‑press duration on the server API.

@javier-godoy javier-godoy merged commit 52bcc98 into master Sep 24, 2025
6 checks passed
@javier-godoy javier-godoy deleted the issue-149 branch September 24, 2025 10:56
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Sep 24, 2025
@paodb paodb moved this from Pending release to Done in Flowing Code Addons Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Enable "Touch-and-Hold" Gesture as Right-Click Equivalent on Mobile Devices

3 participants