Skip to content

Build process chash when btyacc parse file was created in windows with end of line mark as \r\n#8887

Open
Khalyutin wants to merge 2 commits intoFirebirdSQL:masterfrom
notesoft:patchs
Open

Build process chash when btyacc parse file was created in windows with end of line mark as \r\n#8887
Khalyutin wants to merge 2 commits intoFirebirdSQL:masterfrom
notesoft:patchs

Conversation

@Khalyutin
Copy link
Contributor

if parsing file was created in windows but processing on linux we need  delete windows end of line mark as \r\n (CR + LF) Otherwise, the file will not be found.

more info: https://github.com/ChrisDodd/btyacc/pull/32

…ed delete windows end of line mark as \r\n (CR + LF) Otherwise, the file will not be found.

	more info: ChrisDodd/btyacc#32
@aafemt
Copy link
Contributor

aafemt commented Feb 8, 2026

Such problems are usually solved by .gitattributes file.

@Khalyutin
Copy link
Contributor Author

Such problems are usually solved by .gitattributes file.

Yes, of course. But we tried to eliminate the root cause of the problem so that others wouldn't have to waste resources trying to localize it in the future. :)

@Khalyutin Khalyutin marked this pull request as ready for review February 8, 2026 11:57
@aafemt
Copy link
Contributor

aafemt commented Feb 8, 2026

Will you also fix cmd.exe that cannot process files with LF-only EoLNs?

@Khalyutin
Copy link
Contributor Author

Will you also fix cmd.exe that cannot process files with LF-only EoLNs?

source code of ms command interpreter not include in FirebirdSQL/firebird/extern/

@hvlad
Copy link
Member

hvlad commented Feb 8, 2026

Why not pickup commit from original source tree ?

@Khalyutin
Copy link
Contributor Author

Why not pickup commit from original source tree ?

the source tree is very different from the version of btyacc in extern/btyacc/ start from "read_from_file()" in original insted of "fopen()" in extern/btyacc/

Adding read_from_file() may require further changes, up to replacing the entire library :(.

As a result, fixing a known compilation error can addition unknown parsing errors...

I think the risk of taking a significant block of code from the btyacc original source is unjustified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants