Draft
Conversation
This is used to communicate about what the LocalStorageQueue will look like, using mostly the types But because they are quite similar for InMemoryQueue we also add the unit test that should pass and some more precisions
camillecroci
force-pushed
the
cc/local-storage-queue
branch
from
08f31df to
1eb783c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Create specs for LocalStorageQueue.
Why
We try to make as explicit as possible what the LocalStorageQueue will look like before implementing it.
Because the types are quite close to InMemoryQueue, we are using the unit tests (and some more details) as a contract definition.
Like this, we can discuss if we are happy with this before implementation, or if anything might be missing.