Add waypoint radius input to missions page#1184
Open
1Blademaster wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a waypoint radius control to the GCS Missions page and wires it through Redux + Socket.IO to update the corresponding autopilot parameter, also visualizing the radius around mission waypoints on the map.
Changes:
- Add
set_waypoint_radiusSocket.IO endpoint on the radio side that selects the correct parameter name based on vehicle type and firmware. - Add a Redux emitter/action to send waypoint radius updates from the GCS to the radio.
- Add a Missions-page
NumberInputfor waypoint radius and render waypoint-radius rings on the mission map.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| radio/app/endpoints/nav.py | Adds server-side waypoint radius setter with param-name selection by vehicle type/firmware. |
| gcs/src/redux/slices/paramsSlice.js | Adds emitSetWaypointRadius action to drive Socket.IO emission. |
| gcs/src/redux/middleware/emitters.js | Emits set_waypoint_radius over Socket.IO when the new action fires. |
| gcs/src/missions.jsx | Adds debounced waypoint radius input and passes value into the map. |
| gcs/src/components/missions/missionsMap.jsx | Threads waypointRadius prop into the map’s MissionItems rendering. |
| gcs/src/components/mapComponents/missionItems.jsx | Draws radius rings (GeoJSON + map layer) around displayed mission items. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.