Skip to content

Handle heartbeat timeout and connection errors #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1Blademaster merged 2 commits into from
Feb 28, 2026
Merged

Handle heartbeat timeout and connection errors #1028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f34461b
Handle heartbeat timeout and connection errors
1Blademaster Feb 28, 2026
e1055c3
Address copilot review comments
1Blademaster Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions radio/app/drone.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,24 @@ def __init__(
self.connectionError = str(e)
return

initial_heartbeat = self.master.wait_heartbeat(timeout=5)
if initial_heartbeat is None:
self.logger.error("Heartbeat timed out after 5 seconds")
self.master.close()
try:
initial_heartbeat = self.master.wait_heartbeat(timeout=5)
if initial_heartbeat is None:
self.logger.error("Heartbeat timed out after 5 seconds")
self.master.close()
self.master = None
self.connectionError = "Could not connect to the drone."
return
except Exception as e:
self.logger.error(
"Error while waiting for heartbeat: " + str(e), exc_info=True
)
if self.master is not None:
self.master.close()
self.master = None
self.connectionError = "Could not connect to the drone."
self.connectionError = (
"An error occured while waiting for a heartbeat from the drone."
)
return

self.sendConnectionStatusUpdate(1)
Expand Down