3619: Añadir nuevas funciones de cálculo y pruebas para el informe de impuestos#81
Open
daniel89fg wants to merge 2 commits intomainfrom
Open
3619: Añadir nuevas funciones de cálculo y pruebas para el informe de impuestos#81daniel89fg wants to merge 2 commits intomainfrom
daniel89fg wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Este PR actualiza el informe de impuestos del plugin Informes para que el desglose de impuestos se base en los subtotales calculados del documento (en vez de recalcular desde SQL por líneas), y añade pruebas para casos fiscales especiales (intracomunitarias, bienes usados y agencias de viaje).
Changes:
- Refactor de
ReportTaxespara obtener subtotales por factura usandoCalculator::getSubtotals()y generar filas de informe desde el documento. - Añade tests de regresión/cobertura para operaciones intracomunitarias y regímenes especiales (segunda mano y agencias de viaje, incluyendo margen negativo).
- Sube la versión mínima requerida del core en
facturascripts.ini.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| facturascripts.ini | Actualiza la versión mínima requerida del core para soportar los nuevos cálculos. |
| Controller/ReportTaxes.php | Cambia la generación del reporte a un cálculo por documento usando subtotales y añade utilidades de reparto/validación. |
| Test/main/ReportTaxesTest.php | Añade pruebas para validar el desglose de IVA en escenarios fiscales especiales. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tarea #3619