This repository was archived by the owner on Jun 8, 2024. It is now read-only.
Open
Conversation
Member
Author
|
This might not actually be correct tbh, im not sure if/how javadoc handles the package info classes? |
Collaborator
|
FYI we have custom package-info files in yarn, so removing mojang ones is totally fine. |
Member
Author
|
Yeah, we cannot do anything with them in yarn. This crash was only found in a single specific mc version. |
liach
approved these changes
May 21, 2023
Collaborator
liach
left a comment
liach
left a comment
There was a problem hiding this comment.
Should be good. If this flag check fails, this whole library would have fallen apart way before (for broken inner classes, etc.)
thecatcore
approved these changes
Aug 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should Fix #30