Skip to content

Feature/gba 9/support legacy single plan tests #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RodrigoMNardi merged 2 commits into from
Jun 13, 2026
Merged

Feature/gba 9/support legacy single plan tests #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56bbc67
Fix stage name handling to account for blank names in single plan sce…
RodrigoMNardi Jun 13, 2026
b18a6ae
Add multi_plan? method to configuration and update stage_name logic
RodrigoMNardi Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/github/build/action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@
end

def stage_name(stage_config)
return stage_config.github_check_run_name if @check_suite.pull_request.plans.count == 1
return stage_config.github_check_run_name if @check_suite.pull_request.plans.count == 1 or @name.blank?

Check warning on line 184 in lib/github/build/action.rb

View workflow job for this annotation

GitHub Actions / Rubocop 

[rubocop] reported by reviewdog 🐶
Use `one?` instead. (https://rubystyle.guide#collection-querying)

Raw Output:
lib/github/build/action.rb:184:86: C: Style/CollectionQuerying: Use `one?` instead. (https://rubystyle.guide#collection-querying)
return stage_config.github_check_run_name unless GitHubApp::Configuration.instance.multi_plan?

"#{stage_config.github_check_run_name} - #{@name}"
end
Expand Down
4 changes: 4 additions & 0 deletions lib/helpers/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ def debug?
config.key? 'debug' and config['debug']
end

def multi_plan?
config.key? 'multi_plan?' and config['multi_plan?']
end

def ci_url
return @config['ci']['url'] if @config.key?('ci') && @config['ci'].key?('url')

Expand Down