Closed
Conversation
This was referenced Jan 31, 2025
Contributor
|
Thank you so much for your interest! VPP takes patches at https://gerrit.fd.io/ Using git review to contribute patches is recommended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VPP bihash supports a key-value pair to provision an entry for a table. For example, see
https://github.com/FDio/vpp/blob/master/src/vppinfra/bihash_48_8.h#L39
However, the VPP classifier entry does not support a value. This PR adds a
u64 valueto the classifier entry.The use case is the following value for my 5G UPF on matching a classifier entry. Current classifier code with its
opaque_indexnode andmetadatacannot support my value.