fix: Use expression in signed_number#9
Merged
FBumann merged 1 commit intoFBumann:fix/lp-variable-bound-zerofrom Jan 19, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coroa
changed the title
4 tasks
FBumann
added a commit
that referenced
this pull request
Jan 20, 2026
* Fix -0.0 handling in lp writer * Normalize -0.0 to +0.0 using when(abs(x) == 0).then(0.0).otherwise(x) before formatting * Add release notes * Cast to Float64 first to handle columns that are entirely null (dtype `null`) * fix: make signed_number work on expressions (#9) --------- Co-authored-by: Jonas Hörsch <coroa@posteo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @FBumann ,
thanks for the testing code over in PyPSA#544 , that allowed me to play a bit around. this proposal has the same time characteristics as your proposal, but is a bit cleaner IMHO.
Best,
Jonas