Open
Conversation
Changed Files
|
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
+ Coverage 82.97% 83.51% +0.54%
==========================================
Files 47 47
Lines 4158 4198 +40
Branches 611 614 +3
==========================================
+ Hits 3450 3506 +56
+ Misses 576 561 -15
+ Partials 132 131 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
432d290 to
8ffaf42
Compare
8ffaf42 to
21fc92d
Compare
roedoejet
approved these changes
Apr 27, 2026
| if punctuation in self.all_except_punctuation: | ||
| raise ValueError( | ||
| f"Sorry, the symbol '{punctuation}' occurs in both your declared punctuation and in your other symbol set. Please inspect your text configuration and either remove the symbol from the punctuation or other symbol set." | ||
| f"Sorry, the symbol '{punctuation}' occurs in both your declared punctuation and in your other symbol set. If you are training a model, please inspect your text configuration and either remove the symbol from the punctuation or other symbol set. If you are trying to use an existing model, it was probably trained with an older version of EveryVoice, please downgrade EveryVoice." |
Member
There was a problem hiding this comment.
Is there no way to suggest a version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Two related changes to improve how we handle old and/or incompatible models.
everyvoice checkpoint inspectnow uses the embeddedmodel_infoto directly target the right class, if possible, with the same fallback cascade as before if it doesn't workeveryvoice demoor a specificapp.pyscript like we do on HF should produce more helpful error messages in cases of failures.Fixes?
My hope is to reduce the troubleshooting efforts required next time we try to start a model with the wrong version of EV.
Feedback sought?
@SamuelLarkin the changes in
checkpoint.pyrefactor your code, please review the code carefully@deltork opinion on the error messages since you were troubleshooting the system that brought me to want to make these improvements.
Priority?
normal
Tests added?
yeah, not really. We don't have models saved in the repo accessible for CI, so none of these exception are exercised. I want to create a bank of old models created with various versions of EV for regression testing, but that's not a job for this PR.
How to test?
everyvoice inspecta variety of models and see slightly improved output, and especially no errors due to trying other kinds of models in the cases where the model_info field tells us what the right kind is.Confidence?
high
Version change?
nah
Related PRs?
nope