Markdown: fix images not moving text after it down appropriately#111
Open
DeDiamondPro wants to merge 2 commits intoEssentialGG:masterfrom
Open
Markdown: fix images not moving text after it down appropriately#111DeDiamondPro wants to merge 2 commits intoEssentialGG:masterfrom
DeDiamondPro wants to merge 2 commits intoEssentialGG:masterfrom
Conversation
Johni0702
requested changes
May 8, 2023
src/main/kotlin/gg/essential/elementa/markdown/drawables/ParagraphDrawable.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/gg/essential/elementa/markdown/drawables/ParagraphDrawable.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scaleModifierfromcurrYcalculation because components who use it already pass it their height to maxLineHeight with it applied (seeParagraphDrawableline 110 andTextDrawableline 126)widthRemainingandcurrXso it is accurate for everything and not only textCode used for example:
Before:


After: