feat: Add platform attr to per_file rule - #319
Merged
Merged
Conversation
furtib
force-pushed
the
version-spec-attr-fix
branch
from
August 27, 2026 09:27
28a4821 to
08027e3
Compare
Szelethus
reviewed
Sep 22, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
The PR is mostly trivial, just a question about older bazel versions.
Szelethus
approved these changes
Sep 23, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, though we should eventually shed the overhead of bazel 6. Might be nicer to do it before landing this, but it doesn't matter much. Lets land it.
furtib
force-pushed
the
version-spec-attr-fix
branch
from
September 23, 2026 13:24
08027e3 to
5e1c83c
Compare
furtib
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want the per_file rule to be a drop-in replacement for the monolithic rule.
For this, every attribute of the monolithic rule should be supported in the per_file rule too.
What:
Addresses:
none