Mark scalar subquery results nullable - #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NULLwhen the subquery produces zero rowsExprSchemable::nullableandExprSchemable::to_fieldwith a focused unit testWhy
Rustice's live Snowflake compatibility oracle exposed a valid scalar subquery over an empty result. Execution produced
NULL, but DataFusion propagated the non-nullable inner field and Arrow rejected the result with:Validation
cargo +1.97.0 test -p datafusion-expr -q(249 unit tests and 55 doc/integration tests passed; 3 ignored)cargo +1.97.0 clippy -p datafusion-expr --all-targets -- -D warningscargo +1.97.0 fmt --all -- --check