Repository navigation
Make sure duration parsing/date modification works with DateTimes - #6
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new duration parsing currently coerces all duration components to floats, which can lead to surprising numeric coercions/precision in date arithmetic and should be corrected for predictable behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates duration parsing and date modification logic so ISO8601 durations that include only a time component (e.g., PT1H) are accepted, and so modify_date preserves time information when the start value is a datetime.
Changes:
- Update
modify_dateto parse full ISO8601 durations includingPT...time-only values and to useDateTimewhen the input date string includes a time component. - Add a regression test ensuring end datetime is correctly inferred from a start datetime plus a time-only duration (
PT8H).
File summaries
| File | Description |
|---|---|
| test/field_test.rb | Adds coverage for inferring an end datetime from a start datetime and an ISO8601 PT... duration. |
| lib/tess/rdf/extraction.rb | Reworks modify_date duration parsing and applies calendar vs fixed-unit arithmetic, preserving time when appropriate. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
Fixes #5