Skip to content

Fix append #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loubbrad merged 1 commit into from
Jun 11, 2026
Merged

Fix append #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions ariautils/midi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def _process_channel_pedals(channel: int) -> None:
and pedal_msg_value == 1
):
# Current msg is last one and ON -> remove curr pedal_msg
pedal_msg_idxs_to_remove.append(pedal_msg_idx)
pedal_msg_idxs_to_remove.add(pedal_msg_idx)

# Logic for removing repeated pedal messages and updating
# pedal_down_tick and pedal_down_idx
Expand All @@ -543,12 +543,12 @@ def _process_channel_pedals(channel: int) -> None:
continue
else:
# Pedal is OFF and current msg is OFF -> remove curr pedal_msg
pedal_msg_idxs_to_remove.append(pedal_msg_idx)
pedal_msg_idxs_to_remove.add(pedal_msg_idx)
continue
else:
if pedal_msg_value == 1:
# Pedal is ON and current msg is ON -> remove curr pedal_msg
pedal_msg_idxs_to_remove.append(pedal_msg_idx)
pedal_msg_idxs_to_remove.add(pedal_msg_idx)
continue

pedal_is_useful = _is_pedal_useful(
Expand All @@ -560,10 +560,8 @@ def _process_channel_pedals(channel: int) -> None:
if pedal_is_useful is False:
# Pedal hasn't effected any notes -> remove
assert pedal_down_msg_idx is not None
pedal_msg_idxs_to_remove.append(
pedal_down_msg_idx
) # line 517
pedal_msg_idxs_to_remove.append(pedal_msg_idx)
pedal_msg_idxs_to_remove.add(pedal_down_msg_idx) # line 517
pedal_msg_idxs_to_remove.add(pedal_msg_idx)

# Finished processing pedal, set pedal state to OFF
pedal_down_tick = None
Expand Down
Loading