Skip to content

Test to reproduce OP_EQUALVERIFY issue#8946

Closed
enaples wants to merge 1 commit intoElementsProject:masterfrom
enaples:test-op_equalverify-error
Closed

Test to reproduce OP_EQUALVERIFY issue#8946
enaples wants to merge 1 commit intoElementsProject:masterfrom
enaples:test-op_equalverify-error

Conversation

@enaples
Copy link
Copy Markdown
Collaborator

@enaples enaples commented Mar 18, 2026

Important

26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.

RC1 is scheduled on March 23rd

The final release is scheduled for April 15th.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

Test to reproduce OP_EQUALVERIFY issues (#8674 and #4871 ) taking into account the new format of hsm_secret (mnemonic).

Changelog-None

@madelinevibes madelinevibes added this to the 26.06 milestone Mar 20, 2026
@madelinevibes madelinevibes added the QA Blockstream QA team have reproduced, or a test has been created! Look for the linked PR/Issue label Mar 20, 2026
@cdecker
Copy link
Copy Markdown
Member

cdecker commented May 4, 2026

Rebased on top of master to see if it passes.

@cdecker cdecker force-pushed the test-op_equalverify-error branch from df4a614 to 83714b5 Compare May 4, 2026 10:31
@madelinevibes madelinevibes added PLEASE clear CI 🫠 Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. labels May 4, 2026
@Lagrang3
Copy link
Copy Markdown
Collaborator

Lagrang3 commented May 8, 2026

I don't understand how this test is useful.
You remove the hsm_secret file, then no wonder why you can't spend those funds.

Should we be testing the transition from the old hsm_secret format to the new one?
I don't think we support such transition. You just get a completely different set of secrets, even the node id changes AFAIK.
@sangbida

@enaples
Copy link
Copy Markdown
Collaborator Author

enaples commented May 8, 2026

True. The only purpose of this test is to reproduce the pointed issue.

No need to be merged because it is expected to fail.

@Lagrang3
Copy link
Copy Markdown
Collaborator

Lagrang3 commented May 8, 2026

True. The only purpose of this test is to reproduce the pointed issue.

No need to be merged because it's is expected to fail.

@enaples thank you.
I am closing this.

@Lagrang3 Lagrang3 closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PLEASE clear CI 🫠 QA Blockstream QA team have reproduced, or a test has been created! Look for the linked PR/Issue Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants