Skip to content

Various updates#677

Open
peterstadler wants to merge 7 commits into
developfrom
various-updates
Open

Various updates#677
peterstadler wants to merge 7 commits into
developfrom
various-updates

Conversation

@peterstadler

Copy link
Copy Markdown
Member

This PR incorporates two major changes which I hope will make the test setup more robust:

  1. I added the WeGA ID to sort indices in 406ff3d to make indices unique und sorting reproducible (addressing the failed job issue at https://github.com/Edirom/WeGA-WebApp/actions/runs/27053509767)
  2. I removed the caching of failed requests in ff1f404. When a request to an external resource (i.e. Wikidata) fails, this will not be cached anymore so you can simply hit ant test again and the request is sent again (whereas the successful requests will be delivered from the cache). That does not help the Github actions but will help local testing.

Also, I couldn't help fixing some other minor issues while I was seeing them, e.g. switching links from "http" to "https" in 4e3056d

to make indices unique und sorting reproducible
to only cache responses with status codes 2xx, or 4xx.
since the wrapper request to the manifest.json is already cached at `view-json.xql`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant