Geolab base 1.0.1 - #64
Open
sparafina-earthscope wants to merge 17 commits into
Open
Conversation
USE_TIMESTAMP_VERSION was forcing the shared release job to discard any semantic version entered when manually running the release job, always substituting a UTC timestamp instead.
Bakes the release version into the image's org.opencontainers.image.version label via DOCKER_EXTRA_OPTIONS, alongside the existing IMAGE_AUTHORS/PYTHON_VERSION args.
Docker doesn't validate ARG values, so an empty --build-arg or ARG default would silently bake an empty version label/env into the image.
No default means an omitted --build-arg now fails the guard added in abbc516 instead of silently baking in a stale version.
Adds a step before building the platform image explaining that CHANGELOG.md must be updated by hand and that GEOLAB_VERSION is now required (no default) rather than optional metadata.
Surfaces it as an editable field on GitLab's "Run pipeline" page, so it can be overridden without editing and committing .gitlab-ci.yml for each release.
No default forces it to be set explicitly on the "Run pipeline" page for every build; left blank, the Dockerfile guard fails the build instead of silently baking in a stale version.
Notes that the official image build sets GEOLAB_VERSION on the "Run pipeline" page rather than via a manual --build-arg, and that it has no default there either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1.0.1]
Added
Changed