Generalize parts of post_rof_mod to handle fields with ungridded dims#632
Open
billsacks wants to merge 1 commit intoESCOMP:mainfrom
Open
Generalize parts of post_rof_mod to handle fields with ungridded dims#632billsacks wants to merge 1 commit intoESCOMP:mainfrom
billsacks wants to merge 1 commit intoESCOMP:mainfrom
Conversation
This will be needed for the water tracer work. I haven't yet generalized the code for removing negative runoff; that will be done later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This will be needed for the water tracer work. I haven't yet generalized the code for removing negative runoff; that will be done later.
(This is similar to the changes in #628 but now for post_rof_mod.)
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) - no, bfb
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
In the context of cesm3_0_alpha08e, ran:
All tests passed and were bit-for-bit, though with these failures that also failed in the baselines: