Skip to content

TUV-x photolysis#1471

Open
fvitt wants to merge 8 commits intoESCOMP:cam_developmentfrom
fvitt:tuvx_photo
Open

TUV-x photolysis#1471
fvitt wants to merge 8 commits intoESCOMP:cam_developmentfrom
fvitt:tuvx_photo

Conversation

@fvitt
Copy link
Collaborator

@fvitt fvitt commented Jan 13, 2026

This provides the option to use the TUV-x library to compute photo-chemical rates in-line as an alternative to the traditional table look up method.

Closes #757

fvitt added 2 commits January 7, 2026 10:28
@fvitt
TUV-x mods merged from tuvx_jun_cld branch
0ec3468
@fvitt
tuvx lib build/cmake updates
2511721 
	modified:   .gitmodules
	modified:   cime_config/buildlib
	modified:   libraries/tuv-x (new commits)
jimmielin
jimmielin requested changes Jan 22, 2026
View reviewed changes
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fvitt - I had some minor suggested changes that are hopefully straightforward.

@fvitt
changes for code review comments; remove unused modules
f193be9 
	deleted:    src/chemistry/mozart/mo_setz.F90
	deleted:    src/chemistry/mozart/mo_tuv_inti.F90
	modified:   src/chemistry/mozart/chemistry.F90
	modified:   src/chemistry/mozart/mo_gas_phase_chemdr.F90
	modified:   src/chemistry/mozart/mo_tuvx.F90
@fvitt fvitt requested a review from jimmielin January 29, 2026 15:48
nusbaume
nusbaume requested changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this in @fvitt! I had some cleanup requests in the python code, but otherwise only had a couple other comments. Hopefully none of my requests will cause any issues, but if you find that they do please let me know!

@fvitt fvitt self-assigned this Feb 3, 2026
@fvitt
scripts clean up as suggested by reviewer
22003f5 
	modified:   cime_config/buildlib
	modified:   cime_config/buildnml
	modified:   cime_config/testdefs/testmods_dirs/cam/carma_mixed_sulfate/user_nl_cam
cacraigucar
cacraigucar requested changes Feb 3, 2026
View reviewed changes
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected an aux_cam regression test. Can you modify an existing test to turn this on (or is there one already)?

@fvitt
minor code cleanup
9749a7d 
	modified:   src/chemistry/mozart/chemistry.F90
	modified:   src/chemistry/mozart/mo_jeuv.F90
cacraigucar
cacraigucar reviewed Feb 3, 2026
View reviewed changes
@fvitt fvitt requested a review from nusbaume February 3, 2026 19:43
@fvitt
Copy link
Collaborator Author

fvitt commented Feb 3, 2026

@cacraigucar

TUV-x is turned on in this aux_cam test:

aux_cam: SMS_D_Ln9.f19_f19_mg17.FWma2000climo.derecho_intel.cam-outfrq9s_waccm_ma_mam4              # WACCM MA MAM4

See changes here:
https://github.com/ESCOMP/CAM/pull/1471/changes#diff-d1ec6e7c15fbf6c2148ef4c31be28506c102b8cf6811cb4a9dfc163edde61fd8

nusbaume
nusbaume requested changes Feb 4, 2026
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving my concerns @fvitt!

However, looking over the code again I realized that there might be no need to create a build variable in the CMake python functions, as I believe everything can just use case.get_value(), so I have a couple remaining change requests related to that (along with a typo fix). Otherwise everything else looks good!

cacraigucar
cacraigucar requested changes Feb 4, 2026
View reviewed changes
fvitt added 3 commits February 4, 2026 16:46
@fvitt
futher changes per code review
e2ff919 
	modified:   cime_config/buildlib
	modified:   cime_config/testdefs/testmods_dirs/cam/carma_mixed_sulfate/user_nl_cam
@fvitt
use tuv-x tag v0.14.1
100f11d
@fvitt
replace muscia assert error handling with endrun in cam code
c2790d4 
	modified:   src/chemistry/mozart/mo_tuvx.F90
@fvitt fvitt requested review from cacraigucar and nusbaume February 5, 2026 22:57
nusbaume
nusbaume approved these changes Feb 6, 2026
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great to me now. Thanks for getting this brought in @fvitt!

@K20shores
Copy link

K20shores commented Feb 6, 2026

Everything looks great to me now. Thanks for getting this brought in @fvitt!

Must second this. Quite literally could not have happened without you @fvitt. Your efforts are much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmielin jimmielin jimmielin approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

@nusbaume nusbaume nusbaume approved these changes

+1 more reviewer

@K20shores K20shores K20shores left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@fvitt fvitt

Labels

None yet

Projects

CAM Development
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fvitt @K20shores @jimmielin @cacraigucar @nusbaume