[Refactor] domain 레이어에서 가지는 request dto 의존성을 제거합니다.#512
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors several repository and use case methods to accept primitive types or individual parameters instead of DTO request objects, such as CheckValidTokenRequest, ReportRequest, and ChangeNicknameRequest. This decoupling simplifies the domain layer and requires updates across implementations, interfaces, and unit tests. The review feedback suggests improving error handling in UserRepositoryImpl by explicitly matching all ApiResult cases and enhancing code readability by using named arguments and trailing commas in function calls and definitions.
app/src/main/java/com/eatssu/android/data/remote/repository/UserRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/eatssu/android/data/remote/repository/ReportRepositoryImpl.kt
Show resolved
Hide resolved
app/src/main/java/com/eatssu/android/domain/usecase/review/PostReportUseCase.kt
Show resolved
Hide resolved
...c/test/java/com/eatssu/android/domain/usecase/review/ReviewDelegatingUseCasesBehaviorSpec.kt
Outdated
Show resolved
Hide resolved
...c/test/java/com/eatssu/android/domain/usecase/review/ReviewDelegatingUseCasesBehaviorSpec.kt
Outdated
Show resolved
Hide resolved
.../java/com/eatssu/android/presentation/cafeteria/review/report/ReportViewModelBehaviorSpec.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
PeraSite
left a comment
PeraSite
left a comment
There was a problem hiding this comment.
오 너무 우아한데요 좋아요!! 비슷한 구조로 파라미터가 4~5개씩 되는 경우만 주의하면 좋겠네요. 💯
2 participants
Summary
domain 레이어에서 가지는 request dto 의존성을 제거합니다.
Describe your changes
DTO가 아닌 낱알의 필드(nickname, token)등으로 전달하도록 수정했습니다.
필드가 많지 않은 경우에는 별도의 도메인 모델을 생성하지 않고 낱알의 필드로 전달하는 것이 좋을 것 같다고 판단했습니다.
다행히 많이 수정이 되어있어서, 작업사항이 많지는 않습니다.
Issue
To reviewers