Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the writeMenuReview method across the repository, use case, and test layers to include a menuId parameter. This change ensures that the review and its 'like' status are correctly associated with a specific menu item, replacing the previous logic that relied on the first element of a list. A suggestion was made to use the Elvis operator for a more idiomatic Boolean conversion in the repository implementation.
app/src/main/java/com/eatssu/android/data/remote/repository/ReviewRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
Kotlin 메타데이터 버전 불일치로 빌드 불가 문제를 해결하기 위함
…viewRepositoryImpl.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
PeraSite
approved these changes
Mar 27, 2026
Member
PeraSite
left a comment
There was a problem hiding this comment.
갑자기 빌드 오류가 왜 생겼나 했더니 이런 이유였군용 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes
추적
POST /v2/reviews/menu에서 menuLike=null를 받으면, menu리뷰 작성 API인데, menuId가 없어서 NPE이 발생합니다.해결
FIXED(단일 메뉴) 리뷰는 menuLike를 항상 보내고, 좋아요를 안 눌렀으면 IsLike=false로 내려가도록 바꿨습니다.
인간 테스트 결과
Issue
To reviewers
빌드가 안되는 문제를 겪어서 관련 트러블슈팅 기록을 함께 남깁니다.
연쇄적 빌드 실패 문제 해결 관련
1. Kotlin 메타데이터 버전 불일치로 인한 빌드 실패
kotlinx-metadata-jvm이 2.0까지만 지원하여 메타데이터 버전 불일치 문제 발생→ Hilt 및 관련 의존성을 최신 버전으로 업그레이드하여 해결
2. Hilt DI 주입 실패 (protected visibility 이슈)
Dagger injector does not have access to kotlin protected fieldsprotected는 같은 패키지 접근을 허용하지 않으며,Dagger(Hilt)의 코드 생성 클래스에서 접근 불가
→
@Inject필드를protected→public(default)으로 변경하여 해결한 줄 요약