fix(kms): auto-append /prpc to onboard source_url #504
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onboard RPC handler now normalizes source_url by appending /prpc when it's not already present, matching the behavior of dstack-util. This allows callers to pass just the base URL (e.g. https://kms.example.com:9201) without needing to know the /prpc suffix.
kvinwang
force-pushed
the
fix/onboard-source-url-normalize
branch
from
d8bfe8a to
e1f34b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
source_urlin the Onboard RPC handler by auto-appending/prpcwhen missingdstack-util(main.rs) andsystem_setup.rshttps://kms.example.com:9201) without knowing the internal/prpcpath prefixContext
Currently
source_urlis passed verbatim toRaClient::new(), which constructs URLs as{source_url}/{method}?json. Without the/prpcsuffix, requests hit the wrong path and get 404s.The web UI (
onboard.html) works around this by appending/prpcin JavaScript, but direct API callers (e.g.curl) must know to include it.Same fix already merged into Phala-Network/dstack-cloud master.
Test plan
cargo fmt --checkpassescargo clippy -D warningspassessource_url = "https://host:9201/prpc"still works (no double/prpc)source_url = "https://host:9201"now works (auto-appended)source_url = "https://host:9201/"now works (trailing slash trimmed)