GLTFLoader: support MSFT DDS texture sources (MSFT_texture_dds)#265
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support in the AssetLoader glTF pipeline for selecting DDS image sources declared via the MSFT_texture_dds extension, allowing DDS textures to be loaded when present (and reducing spurious “missing standard image” warnings when DDS is used as the supported alternative).
Changes:
- Parse
MSFT_texture_ddsontinygltf::Textureobjects and prefer the extension-provided image source during texture loading. - Add warning post-processing to suppress tinygltf “missing standard image” warnings when DDS alternatives are available.
- Introduce helper utilities for source validation, image availability checks, and warning string cleanup.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheMostDiligent
merged commit 9413387
into
DiligentGraphics:master
55 of 56 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Vendor/MSFT_texture_dds/README.md