-
Notifications
You must be signed in to change notification settings - Fork 678
testing: testcafe-hammerhead build testing #8413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This pull request has been automatically marked as stale because it has not had any activity for a long period. It will be closed and archived if no further activity occurs. However, we may return to this pull request in the future. If it is still relevant or you have any additional information regarding it, please leave a comment and we will keep it open. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds test coverage for a hammerhead issue (gh-3046) related to Web Workers with module type, and temporarily updates the testcafe-hammerhead dependency to a custom build hosted on GitHub for testing purposes.
Key Changes:
- Adds functional test suite for Web Worker module type handling with importScripts
- Updates testcafe-hammerhead dependency from npm registry version to a GitHub-hosted custom build
- Includes HTML page, worker script, and TestCafe test fixtures to validate the fix
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/functional/fixtures/hammerhead/gh-3046/testcafe-fixtures/index.js | TestCafe fixture testing Web Worker module behavior with debug statements |
| test/functional/fixtures/hammerhead/gh-3046/test.js | Test runner configuration for the worker module test |
| test/functional/fixtures/hammerhead/gh-3046/pages/worker.js | Simple worker script that responds to messages |
| test/functional/fixtures/hammerhead/gh-3046/pages/index.html | HTML page demonstrating Web Worker with module type |
| package.json | Updates testcafe-hammerhead dependency to custom GitHub URL |
| package-lock.json | Reflects dependency changes and peer dependency updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
test/functional/fixtures/hammerhead/gh-3046/testcafe-fixtures/index.js
Outdated
Show resolved
Hide resolved
test/functional/fixtures/hammerhead/gh-3046/testcafe-fixtures/index.js
Outdated
Show resolved
Hide resolved
…-fixtures/index.js Co-authored-by: Copilot <[email protected]>
Purpose
Describe the problem you want to address or the feature you want to implement.
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Provide a link to the existing issue(s), if any.
Pre-Merge TODO