Repository navigation
Charts: convert the BaseWidget into an ES6 class and improve typing - #35302
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Broad class migration spans 15 files and warrants final human review.
Review effort: Lite
Findings: None
What changed in this PR
Converts the visualization BaseWidget to an ES6 class while improving typing across related widgets.
Changes:
- Updates widget inheritance and lifecycle methods.
- Adds plugin member typings.
- Updates tests and supporting DOM/options APIs.
| File | Description |
|---|---|
packages/devextreme/testing/tests/DevExpress.viz.core/baseWidget.tests.js |
Updates BaseWidget test setup. |
packages/devextreme/js/__internal/viz/vector_map/vector_map.ts |
Modernizes widget overrides and plugin typing. |
packages/devextreme/js/__internal/viz/tree_map/tree_map.base.ts |
Updates lifecycle methods and data-source typing. |
packages/devextreme/js/__internal/viz/sparklines/sparkline.ts |
Adds data-source plugin typing. |
packages/devextreme/js/__internal/viz/sparklines/base_sparkline.ts |
Updates tooltip handling and typing. |
packages/devextreme/js/__internal/viz/sankey/sankey.ts |
Adds data-source plugin typing. |
packages/devextreme/js/__internal/viz/range_selector/range_selector.ts |
Updates overrides and data-source typing. |
packages/devextreme/js/__internal/viz/gauges/base_gauge.ts |
Updates lifecycle methods and member typing. |
packages/devextreme/js/__internal/viz/funnel/funnel.ts |
Adds data-source plugin typing. |
packages/devextreme/js/__internal/viz/core/tooltip.ts |
Defines tooltip plugin member types. |
packages/devextreme/js/__internal/viz/core/data_source.ts |
Defines data-source plugin member types. |
packages/devextreme/js/__internal/viz/core/base_widget.ts |
Converts the core widget to an ES6 class. |
packages/devextreme/js/__internal/viz/core/annotations.ts |
Defines annotation plugin member types. |
packages/devextreme/js/__internal/core/widget/dom_component.ts |
Makes the element wrapper protected. |
packages/devextreme/js/__internal/core/options/m_index.ts |
Allows optional silent-option arguments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dmlvr
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DevExpress/devextreme-private#5191