T1335525 - Scheduler - Repeated hour is not represented during the Egypt fall-back DST transition - #35295
Draft
sjbur wants to merge 11 commits into
Draft
T1335525 - Scheduler - Repeated hour is not represented during the Egypt fall-back DST transition#35295sjbur wants to merge 11 commits into
sjbur wants to merge 11 commits into
Conversation
Shift by the extra time of visible days only, so hidden weekdays and a range that starts inside the fallback no longer place the appointment on the wrong column. Co-authored-by: Cursor <cursoragent@cursor.com>
…n the grid Stop the current-time marker at the last visible day before a hidden weekday, and shift an appointment from its displayed hour unless that hour is the repeated one. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…nto scheduler-dst-fallback-simple # Conflicts: # packages/devextreme/js/__internal/scheduler/__tests__/cairo_repeated_hour.test.ts
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Partial repeated-hour ranges can omit valid cells, and appointment processing repeatedly rebuilds DST plans.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds fall-back DST support to Scheduler timeline views so repeated hours render and position appointments correctly.
Changes:
- Generates additional timeline cells for repeated hours.
- Updates headers, scrolling, indicators, and appointment geometry.
- Adds Cairo DST coverage and updates Pacific expectations.
| File | Description |
|---|---|
timeline.markup.tests.js |
Uses dynamic timeline cell counts. |
pacificTime.tests.js |
Updates fall-back indicator position. |
work_space.ts |
Supplies DST-aware cell-count and scroll data. |
view_data_generator.ts |
Generates repeated-hour cells. |
date_header_data_generator.ts |
Supports variable day spans. |
timeline.ts |
Adjusts timeline indexing and scrolling. |
get_week_intervals.ts |
Extends timeline layout intervals. |
get_minutes_cell_intervals.ts |
Stretches repeated-hour intervals. |
generate_grid_view_model.ts |
Shifts appointment geometry. |
repeated_hour.ts |
Adds repeated-hour utilities. |
repeated_hour.cairo.test.ts |
Tests Cairo utility behavior. |
types.ts |
Extends cell-count configuration. |
date_header_cell.tsx |
Sizes variable-span headers. |
cairo_repeated_hour.test.ts |
Adds Scheduler integration coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Repeated-hour detection incorrectly follows the browser time zone instead of the Scheduler’s configured time zone.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (2)
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Configured timezones still produce incorrect fallback coordinates, overlapping subsequent-day cells, and wrong repeated-hour labels.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (3)
Resolved since last review (1)
Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.