Repository navigation
DataGrid - Remove deprecated 'rowTemplate' option - #35280
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified in the reviewed changes.
Review effort: Lite
Findings: None
What changed in this PR
Removes the deprecated DataGrid rowTemplate option while retaining dataRowTemplate support.
Changes:
- Removes legacy runtime handling, typings, and deprecation metadata.
- Removes framework-wrapper bindings.
- Updates supported-template behavior and related tests.
| File | Summary |
|---|---|
packages/devextreme/ts/dx.all.d.ts |
Removes deprecated declarations. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/virtualScrolling.integration.tests.js |
Migrates virtual-scrolling template tests. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/selection.tests.js |
Updates selection coverage. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/rowsView.tests.js |
Updates row-rendering tests. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/rowDragging.tests.js |
Removes legacy dragging coverage. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/masterDetail.integration.tests.js |
Migrates master-detail coverage. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/keyboardNavigation.realControllers.tests.js |
Migrates keyboard tests. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/errorHandling.tests.js |
Migrates error-row coverage. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/editing.tests.js |
Migrates editing tests. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/dataGrid.tests.js |
Removes legacy API tests. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/contextMenuView.tests.js |
Removes legacy context-menu coverage. |
packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/adaptiveColumns.tests.js |
Migrates adaptive-column coverage. |
packages/devextreme/testing/tests/DevExpress.knockout/dataGrid.tests.js |
Updates Knockout template coverage. |
packages/devextreme/js/ui/data_grid.d.ts |
Removes the public legacy option and type. |
packages/devextreme/js/ui/data_grid_types.d.ts |
Removes the legacy type export. |
packages/devextreme/js/__internal/grids/grid_core/virtual_scrolling/m_virtual_scrolling.ts |
Updates virtual-row wrapping. |
packages/devextreme/js/__internal/grids/grid_core/views/m_rows_view.ts |
Removes legacy row rendering. |
packages/devextreme/js/__internal/grids/grid_core/views/m_columns_view.ts |
Simplifies row wrapping. |
packages/devextreme/js/__internal/grids/grid_core/search/m_search.ts |
Limits highlighting to dataRowTemplate. |
packages/devextreme/js/__internal/grids/grid_core/m_types.ts |
Removes the internal option type. |
packages/devextreme/js/__internal/grids/data_grid/m_widget_base.ts |
Removes deprecation metadata. |
packages/devextreme-vue/src/data-grid.ts |
Removes Vue legacy bindings. |
packages/devextreme-react/src/data-grid.ts |
Removes React legacy mappings. |
packages/devextreme-angular/src/ui/data-grid/index.ts |
Removes Angular legacy bindings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
added 2 commits
September 23, 2026 21:16
Tucchhaa
force-pushed
the
remove_rowTemplate_26_2
branch
from
September 23, 2026 13:17
cc222d3 to
e539506
Compare
| this.getView('gridView').render(this.$element()); | ||
| } | ||
|
|
||
| protected _setDeprecatedOptions() { |
Contributor
There was a problem hiding this comment.
now we can remove the whole method
may be postponed for next PR
anna-shakhova
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rowTemplateis deprecated anddataRowTemplateshould be sed instead.This PR remove rowTemplate. Test for rowTemplate were either rewritten for dataRowTemplate or removed, since dataRowTemplate has an equivalent test.
Difference between rowTemplate and dataRowTemplate is that rowTemplate can used to customize data rows and group rows, but dataRowTemplate is only for data rows.
However, user still has the ability to customize group rows using onRowPrepared API