Conversation
Detect ~/.kiro/ directory, auto-configure MCP at ~/.kiro/settings/mcp.json using standard mcpServers format. Adds install, uninstall, detection test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
dLo999
left a comment
There was a problem hiding this comment.
Review Summary
Adds Kiro CLI as the 11th auto-detected coding agent. Detects ~/.kiro/ directory, installs MCP config to ~/.kiro/settings/mcp.json using standard mcpServers format. Follows existing patterns exactly — reuses cbm_install_editor_mcp() / cbm_remove_editor_mcp(), adds struct field, detection, print, install, uninstall, and test.
Findings
- [nit] src/cli/cli.c:2429-2433 — The "none found" condition now has 10 negated booleans. Consistent with existing pattern but growing unwieldy. Future consideration: count true agents instead of negating each.
- [nit] src/cli/cli.c:2630 —
cbm_mkdir_p(settings_dir, 0755)matches other editor blocks (e.g. OpenClaw). Standard for user config dirs under~/. - [question] src/cli/cli.c:2937 —
snprintf(..., 1024)for path buffer is a pre-existing pattern across all editor integrations. Latent risk if home path > 1024 chars, but not introduced by this PR. - [question] tests/test_cli.c — Test covers detection only, not install/uninstall. Matches coverage level of other editor tests in the file.
No findings introduced by this PR — all observations are pre-existing patterns that the new code correctly follows.
CI Status
No CI checks on fork branch. Local testing: 2741 tests passed, 0 regressions. Manual verification of detection, install, uninstall, and missing-dir scenarios all pass.
Verdict
APPROVE — Clean pattern-following implementation. All 4 files match existing conventions. New test added. No bugs or security issues introduced.
|
The new agent should be added to README.md? For example here: https://github.com/DeusData/codebase-memory-mcp?tab=readme-ov-file#multi-agent-support |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Good catch — pushed a commit adding Kiro to the README:
|
Closes #96
Summary
Adds Kiro CLI as a detected and auto-configured coding agent, following the existing editor integration patterns. Kiro uses
~/.kiro/settings/mcp.jsonwith the standardmcpServersformat.Changes
src/cli/cli.h: Addedbool kirotocbm_detected_agents_tstructsrc/cli/cli.c: Detection (~/.kiro/dir check), install (cbm_install_editor_mcpto~/.kiro/settings/mcp.json), uninstall, and print supportsrc/main.c: Added "Kiro" to help text agent listtests/test_cli.c: Addedcli_detect_agents_finds_kirotest and updatedcli_detect_agents_none_foundConfig format
Kiro CLI uses the standard
mcpServersformat at~/.kiro/settings/mcp.json:{ "mcpServers": { "codebase-memory-mcp": { "command": "/path/to/codebase-memory-mcp" } } }Source: https://kiro.dev/docs/cli/mcp/
Test results
Build: Compiles cleanly on macOS (Apple Clang, arm64)
Test suite: 2741 passed (including new Kiro detection test), 1 pre-existing flaky timing test (
test_incremental.c:371)Manual verification (created temporary
~/.kiro/directory, tested full lifecycle, cleaned up):install --dry-run)~/.kiro/settings/mcp.json~/.kiro/settings/directory created,mcp.jsonwritten with correctmcpServersJSON and binary pathcodebase-memory-mcpentry removed frommcpServers, file preserved with empty object~/.kiro/presentGenerated with agent-team via /issue