Skip to content

feat: add Kiro CLI support (#96)#174

Open
dLo999 wants to merge 2 commits intoDeusData:mainfrom
dLo999:feat/kiro-cli-support
Open

feat: add Kiro CLI support (#96)#174
dLo999 wants to merge 2 commits intoDeusData:mainfrom
dLo999:feat/kiro-cli-support

Conversation

@dLo999
Copy link
Copy Markdown

@dLo999 dLo999 commented Mar 29, 2026

Closes #96

Summary

Adds Kiro CLI as a detected and auto-configured coding agent, following the existing editor integration patterns. Kiro uses ~/.kiro/settings/mcp.json with the standard mcpServers format.

Changes

  • src/cli/cli.h: Added bool kiro to cbm_detected_agents_t struct
  • src/cli/cli.c: Detection (~/.kiro/ dir check), install (cbm_install_editor_mcp to ~/.kiro/settings/mcp.json), uninstall, and print support
  • src/main.c: Added "Kiro" to help text agent list
  • tests/test_cli.c: Added cli_detect_agents_finds_kiro test and updated cli_detect_agents_none_found

Config format

Kiro CLI uses the standard mcpServers format at ~/.kiro/settings/mcp.json:

{
  "mcpServers": {
    "codebase-memory-mcp": {
      "command": "/path/to/codebase-memory-mcp"
    }
  }
}

Source: https://kiro.dev/docs/cli/mcp/

Test results

Build: Compiles cleanly on macOS (Apple Clang, arm64)

Test suite: 2741 passed (including new Kiro detection test), 1 pre-existing flaky timing test (test_incremental.c:371)

Manual verification (created temporary ~/.kiro/ directory, tested full lifecycle, cleaned up):

Test Result
Detection (install --dry-run) "Kiro" appears in detected agents list with correct path ~/.kiro/settings/mcp.json
Install (actual) ~/.kiro/settings/ directory created, mcp.json written with correct mcpServers JSON and binary path
Uninstall codebase-memory-mcp entry removed from mcpServers, file preserved with empty object
No ~/.kiro/ present Kiro not detected, silently skipped (no error)

Generated with agent-team via /issue

Detect ~/.kiro/ directory, auto-configure MCP at ~/.kiro/settings/mcp.json
using standard mcpServers format. Adds install, uninstall, detection test.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Author

@dLo999 dLo999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Adds Kiro CLI as the 11th auto-detected coding agent. Detects ~/.kiro/ directory, installs MCP config to ~/.kiro/settings/mcp.json using standard mcpServers format. Follows existing patterns exactly — reuses cbm_install_editor_mcp() / cbm_remove_editor_mcp(), adds struct field, detection, print, install, uninstall, and test.

Findings

  • [nit] src/cli/cli.c:2429-2433 — The "none found" condition now has 10 negated booleans. Consistent with existing pattern but growing unwieldy. Future consideration: count true agents instead of negating each.
  • [nit] src/cli/cli.c:2630 — cbm_mkdir_p(settings_dir, 0755) matches other editor blocks (e.g. OpenClaw). Standard for user config dirs under ~/.
  • [question] src/cli/cli.c:2937 — snprintf(..., 1024) for path buffer is a pre-existing pattern across all editor integrations. Latent risk if home path > 1024 chars, but not introduced by this PR.
  • [question] tests/test_cli.c — Test covers detection only, not install/uninstall. Matches coverage level of other editor tests in the file.

No findings introduced by this PR — all observations are pre-existing patterns that the new code correctly follows.

CI Status

No CI checks on fork branch. Local testing: 2741 tests passed, 0 regressions. Manual verification of detection, install, uninstall, and missing-dir scenarios all pass.

Verdict

APPROVE — Clean pattern-following implementation. All 4 files match existing conventions. New test added. No bugs or security issues introduced.

@jsyrjala
Copy link
Copy Markdown

The new agent should be added to README.md?

For example here:

https://github.com/DeusData/codebase-memory-mcp?tab=readme-ov-file#multi-agent-support

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@dLo999
Copy link
Copy Markdown
Author

dLo999 commented Mar 29, 2026

Good catch — pushed a commit adding Kiro to the README:

  • Updated agent count from 10 to 11 in the feature bullet
  • Added Kiro row to the multi-agent support table with .kiro/settings/mcp.json config path

@DeusData DeusData added enhancement New feature or request editor/integration Editor compatibility and CLI integration labels Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editor/integration Editor compatibility and CLI integration enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for kiro-cli

3 participants