add new flare vaults to yield page#2437
Open
agbanusi wants to merge 6 commits intoDefiLlama:masterfrom
Open
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new Mystic Finance adaptor for the FLARE chain ( Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Adaptor
participant ERC4626 as ERC4626 Provider
participant PriceAPI as Price Provider
participant External as External API
Caller->>Adaptor: call apy(timestamp)
Adaptor->>ERC4626: getERC4626Info(vaults) (concurrent)
Adaptor->>PriceAPI: getPrices(underlyingTokens)
Adaptor->>External: getData(optional vault/APY info)
ERC4626-->>Adaptor: vault info (tvl, decimals, symbol)
PriceAPI-->>Adaptor: token prices
External-->>Adaptor: campaignApr / vaultApr (optional)
Adaptor->>Adaptor: compute tvlUsd, apyBase, apyReward, build metrics
Adaptor-->>Caller: return array of vault metric objects
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/adaptors/mystic-finance/index.js (1)
29-33: Consider partial-failure handling for vault fetches.Using
Promise.allmeans one failing vault request drops the entire adaptor response.Promise.allSettledwould preserve healthy vaults and improve resilience.Resilience-oriented refactor
- const vaultInfos = await Promise.all( + const vaultInfos = await Promise.allSettled( VAULTS.map((vault) => getERC4626Info(vault.address, CHAIN, timestamp) ) ); ... - return VAULTS.map((vault, i) => { - const { tvl, apyBase } = vaultInfos[i]; + return VAULTS.flatMap((vault, i) => { + if (vaultInfos[i].status !== 'fulfilled') return []; + const { tvl, apyBase } = vaultInfos[i].value; ... - return { + return [{ ... - }; + }]; });🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/adaptors/mystic-finance/index.js` around lines 29 - 33, The current use of Promise.all when building vaultInfos with VAULTS.map(... getERC4626Info(...)) causes a single failing getERC4626Info call to reject the whole operation; replace Promise.all with Promise.allSettled to collect per-vault results, then filter the settled results for status === "fulfilled" and map to their .value to build vaultInfos (optionally log or handle rejected entries), keeping the same inputs (VAULTS, getERC4626Info, CHAIN, timestamp) and downstream consumers unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/adaptors/mystic-finance/index.js`:
- Around line 42-46: tvl is used in arithmetic without normalizing its type
which risks precision loss; convert the raw tvl (from vaultInfos[i] /
sdk.api.abi.call().output) to a BigNumber/number-safe representation before
dividing by 10 ** vault.decimals and computing tokenAmount/ tvlUsd. Locate where
tvl is read (variable tvl from vaultInfos[i]) and replace the implicit division
with a normalized value (e.g., parse/BigNumber conversion) so tokenAmount =
normalizedTvl.dividedBy(10 ** vault.decimals) (or equivalent) and then compute
price and tvlUsd using that normalizedTvl to avoid JS precision issues.
---
Nitpick comments:
In `@src/adaptors/mystic-finance/index.js`:
- Around line 29-33: The current use of Promise.all when building vaultInfos
with VAULTS.map(... getERC4626Info(...)) causes a single failing getERC4626Info
call to reject the whole operation; replace Promise.all with Promise.allSettled
to collect per-vault results, then filter the settled results for status ===
"fulfilled" and map to their .value to build vaultInfos (optionally log or
handle rejected entries), keeping the same inputs (VAULTS, getERC4626Info,
CHAIN, timestamp) and downstream consumers unchanged.
Comment on lines
+42
to
+46
| const { tvl, apyBase } = vaultInfos[i]; | ||
| const tokenAmount = tvl / 10 ** vault.decimals; | ||
| const price = | ||
| pricesByAddress[vault.underlyingToken.toLowerCase()] || 0; | ||
| const tvlUsd = tokenAmount * price; |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, verify the file exists and examine the specific lines
find . -name "index.js" -path "*/mystic-finance/*" | head -20Repository: DefiLlama/yield-server
Length of output: 104
🏁 Script executed:
# Search for getERC4626Info to understand what it returns
rg -n "getERC4626Info" --type js -A 5 -B 2Repository: DefiLlama/yield-server
Length of output: 12732
🏁 Script executed:
# Check the vaultInfos structure and tvl usage in mystic-finance adapter
rg -n "vaultInfos|tvl" "src/adaptors/mystic-finance/" --type js -C 3Repository: DefiLlama/yield-server
Length of output: 1868
🏁 Script executed:
# Compare TVL normalization patterns across adapters
rg -n "Number\(" "src/adaptors/" --type js | grep -i "tvl\|liquidity\|amount" | head -20Repository: DefiLlama/yield-server
Length of output: 1893
🏁 Script executed:
# Read getERC4626Info implementation from utils.js
sed -n '470,550p' src/adaptors/utils.jsRepository: DefiLlama/yield-server
Length of output: 2036
🏁 Script executed:
# Check what getERC4626Info returns by looking at the complete function
rg -n "exports.getERC4626Info" -A 80 src/adaptors/utils.js | head -100Repository: DefiLlama/yield-server
Length of output: 2360
🏁 Script executed:
# Check frax adapter's usage of tvl after getERC4626Info
sed -n '23,36p' src/adaptors/frax/index.jsRepository: DefiLlama/yield-server
Length of output: 465
🏁 Script executed:
# Check 40-acres adapter's usage of tvl
sed -n '5,20p' src/adaptors/40-acres/index.jsRepository: DefiLlama/yield-server
Length of output: 578
🏁 Script executed:
# Look for how sdk.api.abi.call output is typically used in other adapters
rg -n "\.output\s*/" src/adaptors --type js | head -15Repository: DefiLlama/yield-server
Length of output: 1303
🏁 Script executed:
# Check if defillama SDK types reveal what abi.call returns
find . -name "*.ts" -o -name "*.d.ts" | xargs grep -l "api.abi.call" 2>/dev/null | head -5Repository: DefiLlama/yield-server
Length of output: 237
🏁 Script executed:
# Check one of the TypeScript files to see how output is typed
sed -n '1,50p' src/adaptors/abracadabra-spell/common.ts | head -40Repository: DefiLlama/yield-server
Length of output: 1308
🏁 Script executed:
# Search for the defillama SDK import and see if there are any type hints
rg -n "sdk.api.abi.call" -B 2 -A 10 src/adaptors/altura/index.js | head -30Repository: DefiLlama/yield-server
Length of output: 48
🏁 Script executed:
# Check if there's any error handling around tvl usage in adapters
rg -n "tvl.*NaN|isFinite.*tvl|Number.*tvl" src/adaptors --type jsRepository: DefiLlama/yield-server
Length of output: 14458
🏁 Script executed:
# Look at pok-vault which explicitly uses Number(ethers.utils.formatEther(tvl))
# to understand why it needs this conversion
cat -n src/adaptors/pok-vault/index.jsRepository: DefiLlama/yield-server
Length of output: 777
🏁 Script executed:
# Look for documentation or test files about sdk.api.abi.call return type
rg -n "output.*string|output.*number|output.*BigInt" src/adaptors --type js -A 2 | head -30Repository: DefiLlama/yield-server
Length of output: 46156
🏁 Script executed:
# Check if mystic-finance adapter has any tests or error handling
find . -name "*mystic*" -type f | head -10Repository: DefiLlama/yield-server
Length of output: 48
🏁 Script executed:
# Look at umami-finance which explicitly does Number(tvlRaw) / 10 ** vault.decimals
sed -n '70,80p' src/adaptors/umami-finance/umamiGmSynthVaults.jsRepository: DefiLlama/yield-server
Length of output: 376
Normalize tvl to a number before division to avoid precision loss and align with existing patterns.
Line 43 performs arithmetic on tvl without explicit conversion. While JavaScript's implicit type coercion allows this to work, tvl comes from sdk.api.abi.call().output (returning blockchain data) and may be a string or large number representation. Direct division can silently lose precision for very large values exceeding JavaScript's safe integer limit (2^53). Similar adapters like umami-finance normalize this value explicitly.
Proposed fix
- const { tvl, apyBase } = vaultInfos[i];
- const tokenAmount = tvl / 10 ** vault.decimals;
+ const { tvl, apyBase } = vaultInfos[i];
+ const tokenAmount = Number(tvl) / 10 ** vault.decimals;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const { tvl, apyBase } = vaultInfos[i]; | |
| const tokenAmount = tvl / 10 ** vault.decimals; | |
| const price = | |
| pricesByAddress[vault.underlyingToken.toLowerCase()] || 0; | |
| const tvlUsd = tokenAmount * price; | |
| const { tvl, apyBase } = vaultInfos[i]; | |
| const tokenAmount = Number(tvl) / 10 ** vault.decimals; | |
| const price = | |
| pricesByAddress[vault.underlyingToken.toLowerCase()] || 0; | |
| const tvlUsd = tokenAmount * price; |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/adaptors/mystic-finance/index.js` around lines 42 - 46, tvl is used in
arithmetic without normalizing its type which risks precision loss; convert the
raw tvl (from vaultInfos[i] / sdk.api.abi.call().output) to a
BigNumber/number-safe representation before dividing by 10 ** vault.decimals and
computing tokenAmount/ tvlUsd. Locate where tvl is read (variable tvl from
vaultInfos[i]) and replace the implicit division with a normalized value (e.g.,
parse/BigNumber conversion) so tokenAmount = normalizedTvl.dividedBy(10 **
vault.decimals) (or equivalent) and then compute price and tvlUsd using that
normalizedTvl to avoid JS precision issues.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/adaptors/mystic-finance/index.js (1)
56-56: Replace magicchainId=14with a named constant.Hardcoding the chain id in the URL makes future edits easy to miss. Prefer a shared constant beside
CHAIN.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/adaptors/mystic-finance/index.js` at line 56, Replace the magic number 14 in the URL template with a named constant defined alongside the existing CHAIN exports; add a constant like MYSTIC_FINANCE_CHAIN_ID (or CHAIN.MYSTIC_FINANCE) near CHAIN and then change the URL construction from `chainId=14` to `chainId=${MYSTIC_FINANCE_CHAIN_ID}` (or `chainId=${CHAIN.MYSTIC_FINANCE}`) where the URL is built using `vault.address` so the chain id is referenced by name rather than a hardcoded literal.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/adaptors/mystic-finance/index.js`:
- Around line 29-33: The current Promise.all call that builds vaultInfos
(VAULTS.map(... getERC4626Info ...)) will reject the whole apy() flow if any
single RPC fails; replace Promise.all with Promise.allSettled for the VAULTS ->
getERC4626Info batch, then process the settled results by keeping only entries
with status === "fulfilled" (use result.value) and skip rejected ones
(optionally log errors), e.g., compute vaultInfos from the settled array using
.flatMap/.filter+map so downstream code receives only successful ERC4626 info
objects while individual vault RPC failures do not break the entire apy() call.
---
Nitpick comments:
In `@src/adaptors/mystic-finance/index.js`:
- Line 56: Replace the magic number 14 in the URL template with a named constant
defined alongside the existing CHAIN exports; add a constant like
MYSTIC_FINANCE_CHAIN_ID (or CHAIN.MYSTIC_FINANCE) near CHAIN and then change the
URL construction from `chainId=14` to `chainId=${MYSTIC_FINANCE_CHAIN_ID}` (or
`chainId=${CHAIN.MYSTIC_FINANCE}`) where the URL is built using `vault.address`
so the chain id is referenced by name rather than a hardcoded literal.
Comment on lines
+29
to
+33
| const vaultInfos = await Promise.all( | ||
| VAULTS.map((vault) => | ||
| getERC4626Info(vault.address, CHAIN, timestamp) | ||
| ) | ||
| ); |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
find . -name "index.js" -path "*/mystic-finance/*" | head -20Repository: DefiLlama/yield-server
Length of output: 104
🏁 Script executed:
cat -n ./src/adaptors/mystic-finance/index.jsRepository: DefiLlama/yield-server
Length of output: 2261
Use Promise.allSettled() to prevent single vault RPC failures from blocking the entire adaptor.
The current Promise.all pattern fails fast—if any vault's RPC call fails, the entire apy() function rejects and no vaults report data. This makes the adaptor completely unavailable if a single vault experiences transient RPC issues.
Replace Promise.all with Promise.allSettled to handle individual vault failures gracefully, and use .flatMap() to skip failed results:
Proposed resilient fetch pattern
const apy = async (timestamp) => {
- const vaultInfos = await Promise.all(
- VAULTS.map((vault) =>
- getERC4626Info(vault.address, CHAIN, timestamp)
- )
- );
-
- // Fetch underlying token prices
const priceKeys = VAULTS.map(
(vault) => vault.underlyingToken
);
- const { pricesByAddress } = await getPrices(priceKeys, CHAIN);
+ const [vaultInfoResults, { pricesByAddress }] = await Promise.all([
+ Promise.allSettled(
+ VAULTS.map((vault) => getERC4626Info(vault.address, CHAIN, timestamp))
+ ),
+ getPrices(priceKeys, CHAIN),
+ ]);
- return VAULTS.map((vault, i) => {
- const { tvl, apyBase } = vaultInfos[i];
+ return VAULTS.flatMap((vault, i) => {
+ const result = vaultInfoResults[i];
+ if (result.status !== 'fulfilled') return [];
+ const { tvl, apyBase } = result.value;
const tokenAmount = tvl / 10 ** vault.decimals;
const price =
pricesByAddress[vault.underlyingToken.toLowerCase()] || 0;
const tvlUsd = tokenAmount * price;
- return {
+ return [{
pool: `${vault.address}-${CHAIN}`,
chain: formatChain(CHAIN),
project: PROJECT_NAME,
symbol: vault.symbol,
tvlUsd,
apyBase,
underlyingTokens: [vault.underlyingToken],
url: `https://app.mysticfinance.xyz/vault?vaultAddress=${vault.address}&chainId=14`,
- };
+ }];
});
};🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/adaptors/mystic-finance/index.js` around lines 29 - 33, The current
Promise.all call that builds vaultInfos (VAULTS.map(... getERC4626Info ...))
will reject the whole apy() flow if any single RPC fails; replace Promise.all
with Promise.allSettled for the VAULTS -> getERC4626Info batch, then process the
settled results by keeping only entries with status === "fulfilled" (use
result.value) and skip rejected ones (optionally log errors), e.g., compute
vaultInfos from the settled array using .flatMap/.filter+map so downstream code
receives only successful ERC4626 info objects while individual vault RPC
failures do not break the entire apy() call.
Contributor
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
src/adaptors/mystic-finance/index.js (1)
29-40:⚠️ Potential issue | 🟠 MajorMake vault RPC fetching resilient to partial failures.
A single
getERC4626Inforejection currently fails the full adaptor response. PreferPromise.allSettledfor vault calls and skip failed vaults so healthy pools still report.Proposed resilient + parallel fetch update
const apy = async (timestamp) => { - const vaultInfos = await Promise.all( - VAULTS.map((vault) => - getERC4626Info(vault.address, CHAIN, timestamp) - ) - ); - - // Fetch underlying token prices const priceKeys = VAULTS.map( (vault) => vault.underlyingToken ); - const { pricesByAddress } = await getPrices(priceKeys, CHAIN); + const [vaultInfoResults, { pricesByAddress }] = await Promise.all([ + Promise.allSettled( + VAULTS.map((vault) => + getERC4626Info(vault.address, CHAIN, timestamp) + ) + ), + getPrices(priceKeys, CHAIN), + ]); - return VAULTS.map((vault, i) => { - const { tvl, apyBase } = vaultInfos[i]; + return VAULTS.flatMap((vault, i) => { + const result = vaultInfoResults[i]; + if (result.status !== 'fulfilled') return []; + const { tvl, apyBase } = result.value; const tokenAmount = tvl / 10 ** vault.decimals; const price = pricesByAddress[vault.underlyingToken.toLowerCase()] || 0; const tvlUsd = tokenAmount * price; - return { + return [{ pool: `${vault.address}-${CHAIN}`, chain: formatChain(CHAIN), project: PROJECT_NAME, symbol: vault.symbol, tvlUsd, apyBase, underlyingTokens: [vault.underlyingToken], url: `https://app.mysticfinance.xyz/vault?vaultAddress=${vault.address}&chainId=14`, - }; + }]; }); };🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/adaptors/mystic-finance/index.js` around lines 29 - 40, Replace the Promise.all call for getERC4626Info with Promise.allSettled over VAULTS.map(v => getERC4626Info(v.address, CHAIN, timestamp)), then filter the settled results for those with status === "fulfilled" and extract result.value into vaultInfos, logging or recording any rejections; next compute priceKeys from the filtered vaults (use the corresponding VAULTS entries or the returned vaultInfos' underlyingToken) and call getPrices only for those keys so a single failing getERC4626Info does not abort the whole adapter (ensure code paths that consume vaultInfos handle the reduced set and handle the case of zero successful vaults).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@src/adaptors/mystic-finance/index.js`:
- Around line 29-40: Replace the Promise.all call for getERC4626Info with
Promise.allSettled over VAULTS.map(v => getERC4626Info(v.address, CHAIN,
timestamp)), then filter the settled results for those with status ===
"fulfilled" and extract result.value into vaultInfos, logging or recording any
rejections; next compute priceKeys from the filtered vaults (use the
corresponding VAULTS entries or the returned vaultInfos' underlyingToken) and
call getPrices only for those keys so a single failing getERC4626Info does not
abort the whole adapter (ensure code paths that consume vaultInfos handle the
reduced set and handle the case of zero successful vaults).
|
Error while running mystic-finance adapter: Test Suites: 1 failed, 1 total |
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/adaptors/mystic-finance/index.js (1)
1-2: Remove unusedsdkimport.The
@defillama/sdkis imported but never used in this file. The actual SDK usage is encapsulated within thegetERC4626Infoutility function.Proposed fix
-const sdk = require('@defillama/sdk'); const { formatChain, getERC4626Info, getPrices } = require('../utils');🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/adaptors/mystic-finance/index.js` around lines 1 - 2, Remove the unused import of the DefiLlama SDK from this module: delete the line that declares "const sdk = require('@defillama/sdk');" since sdk is not referenced in this file and SDK functionality is provided by the existing utility "getERC4626Info" (and other imports like "formatChain" and "getPrices")—ensure only the necessary imports remain at the top of the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/adaptors/mystic-finance/index.js`:
- Around line 1-2: Remove the unused import of the DefiLlama SDK from this
module: delete the line that declares "const sdk = require('@defillama/sdk');"
since sdk is not referenced in this file and SDK functionality is provided by
the existing utility "getERC4626Info" (and other imports like "formatChain" and
"getPrices")—ensure only the necessary imports remain at the top of the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b92c3e4c-bd77-45b3-8e4a-b5eb8b95030d
📒 Files selected for processing (1)
src/adaptors/mystic-finance/index.js
|
Error while running mystic-finance adapter: Test Suites: 1 failed, 1 total |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
src/adaptors/mystic-finance/index.js (1)
29-33:⚠️ Potential issue | 🟠 MajorAvoid fail-fast batching for vault RPCs.
One transient
getERC4626Info()failure still rejects the whole adaptor, so all three pools disappear instead of only the failed vault.Promise.allSettled()is safer here.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/adaptors/mystic-finance/index.js` around lines 29 - 33, Replace the fail-fast Promise.all call that gathers ERC4626 data so a single failing vault doesn’t reject the entire batch: use Promise.allSettled on VAULTS.map(...) calling getERC4626Info(vault.address, CHAIN, timestamp), then filter settled results to keep only those with status "fulfilled" (extracting .value into vaultInfos) and log or record any rejected entries (from .reason) so only the failed vault is skipped and the rest of the adaptor continues to operate.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/adaptors/mystic-finance/index.js`:
- Around line 43-48: The call to getData(...) returns undefined because getData
(in src/adaptors/utils.js) calls axios.get(...) without awaiting or returning
the response body, so the morpho vaults (vaultsApiData) never get populated; fix
getData by awaiting axios.get(...) and returning the parsed response data (e.g.,
response.data) so callers like the getData('https://api.mysticfinance...') in
this file receive the API payload and allow downstream logic (vaultsApiData
population, reward APR and vaultApr override) to run correctly.
- Around line 57-59: The current assignment for apyReward and vaultApr uses
truthy checks that drop valid zero values (apiVault.campaignApr or
apiVault.vaultApr === 0); update the logic in the block that reads vaultsApiData
and sets apiVault, apyReward and vaultApr so it treats 0 as a valid value by
checking explicitly for null/undefined (e.g., test apiVault !== null/undefined
and apiVault.campaignApr !== null/undefined) rather than relying on truthiness;
ensure apyReward and vaultApr pick the API numeric value when present (including
0) and only fall back to null/fallback when truly missing.
---
Duplicate comments:
In `@src/adaptors/mystic-finance/index.js`:
- Around line 29-33: Replace the fail-fast Promise.all call that gathers ERC4626
data so a single failing vault doesn’t reject the entire batch: use
Promise.allSettled on VAULTS.map(...) calling getERC4626Info(vault.address,
CHAIN, timestamp), then filter settled results to keep only those with status
"fulfilled" (extracting .value into vaultInfos) and log or record any rejected
entries (from .reason) so only the failed vault is skipped and the rest of the
adaptor continues to operate.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e08f1f7d-6679-4d15-b519-17e167d31416
📒 Files selected for processing (1)
src/adaptors/mystic-finance/index.js
Comment on lines
+43
to
+48
| try { | ||
| const apiData = await getData('https://api.mysticfinance.xyz/morphoCache/lite?chainId=14'); | ||
| if (apiData && apiData.vaults) { | ||
| vaultsApiData = apiData.vaults; | ||
| } | ||
| } catch{} |
Contributor
There was a problem hiding this comment.
This API fetch never populates APR data with the current helper.
getData()'s GET path in src/adaptors/utils.js:67-75 does not await axios.get(), so this call resolves to undefined and vaultsApiData stays empty. As written, the reward APR and vaultApr override path below never executes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/adaptors/mystic-finance/index.js` around lines 43 - 48, The call to
getData(...) returns undefined because getData (in src/adaptors/utils.js) calls
axios.get(...) without awaiting or returning the response body, so the morpho
vaults (vaultsApiData) never get populated; fix getData by awaiting
axios.get(...) and returning the parsed response data (e.g., response.data) so
callers like the getData('https://api.mysticfinance...') in this file receive
the API payload and allow downstream logic (vaultsApiData population, reward APR
and vaultApr override) to run correctly.
Comment on lines
+57
to
+59
| const apiVault = vaultsApiData.find(v => v.vaultAddress.toLowerCase() === vault.address.toLowerCase()); | ||
| const apyReward = apiVault && apiVault.campaignApr ? apiVault.campaignApr : null; | ||
| const vaultApr = apiVault && apiVault.vaultApr ? apiVault.vaultApr : null; |
Contributor
There was a problem hiding this comment.
Preserve zero APRs from the API.
These truthy checks treat 0 as “missing”. If Mystic returns campaignApr: 0 or vaultApr: 0, the adapter drops the reward APR and keeps the fallback ERC4626 APY instead of the API value.
Proposed fix
- const apiVault = vaultsApiData.find(v => v.vaultAddress.toLowerCase() === vault.address.toLowerCase());
- const apyReward = apiVault && apiVault.campaignApr ? apiVault.campaignApr : null;
- const vaultApr = apiVault && apiVault.vaultApr ? apiVault.vaultApr : null;
+ const apiVault = vaultsApiData.find(
+ (v) => v.vaultAddress.toLowerCase() === vault.address.toLowerCase()
+ );
+ const apyReward = apiVault?.campaignApr ?? null;
+ const vaultApr = apiVault?.vaultApr ?? null;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const apiVault = vaultsApiData.find(v => v.vaultAddress.toLowerCase() === vault.address.toLowerCase()); | |
| const apyReward = apiVault && apiVault.campaignApr ? apiVault.campaignApr : null; | |
| const vaultApr = apiVault && apiVault.vaultApr ? apiVault.vaultApr : null; | |
| const apiVault = vaultsApiData.find( | |
| (v) => v.vaultAddress.toLowerCase() === vault.address.toLowerCase() | |
| ); | |
| const apyReward = apiVault?.campaignApr ?? null; | |
| const vaultApr = apiVault?.vaultApr ?? null; |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/adaptors/mystic-finance/index.js` around lines 57 - 59, The current
assignment for apyReward and vaultApr uses truthy checks that drop valid zero
values (apiVault.campaignApr or apiVault.vaultApr === 0); update the logic in
the block that reads vaultsApiData and sets apiVault, apyReward and vaultApr so
it treats 0 as a valid value by checking explicitly for null/undefined (e.g.,
test apiVault !== null/undefined and apiVault.campaignApr !== null/undefined)
rather than relying on truthiness; ensure apyReward and vaultApr pick the API
numeric value when present (including 0) and only fall back to null/fallback
when truly missing.
Contributor
There was a problem hiding this comment.
pls implement this fix for vaultApr and apyReward @agbanusi
Contributor
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
|
The mystic-finance-lending adapter exports pools: Test Suites: 1 passed, 1 total |
0xkr3p
reviewed
Mar 11, 2026
| } | ||
|
|
||
| if (vaultApr !== null) { | ||
| poolData.apyBase = vaultApr; |
Contributor
There was a problem hiding this comment.
this overwrites the on chain apyBase, we should use onchain figure
0xkr3p
reviewed
Mar 11, 2026
| @@ -0,0 +1,89 @@ | |||
| const sdk = require('@defillama/sdk'); | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit