Skip to content

Batch config variable setting in action.yaml#43

Open
lionello wants to merge 2 commits intomainfrom
lio/batch-config
Open

Batch config variable setting in action.yaml#43
lionello wants to merge 2 commits intomainfrom
lio/batch-config

Conversation

@lionello
Copy link
Member

@lionello lionello commented Mar 10, 2026

Requires CLI version v2.10.0 or newer because it needs DefangLabs/defang#1805. Should we bump this action's major version number?

Huge speed up:

https://github.com/DefangLabs/portal/actions/runs/22907777286/job/66472392040 40s = ~1s/config

vs w/o

https://github.com/DefangLabs/portal/actions/runs/22907955211/job/66471893504 95s = ~2.5s/config

@lionello lionello requested a review from a team as a code owner March 10, 2026 14:07
@lionello lionello changed the title Refactor config variable setting in action.yaml Batch config variable setting in action.yaml Mar 10, 2026
@lionello lionello requested a review from jordanstephens March 10, 2026 17:42
Copy link
Member

@jordanstephens jordanstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

And yes, I think it's a good idea to bump the major version number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants