Closed
Conversation
dopenguin
requested review from
oeninghe-dataport and
warm-coolguy
as code owners
|
dopenguin
force-pushed
the
vue3/fix-memory-leak
branch
5 times, most recently
from
7c96842 to
2e8a936
Compare
dopenguin
force-pushed
the
vue3/fix-memory-leak
branch
from
2e8a936 to
133c2d5
Compare
warm-coolguy
requested changes
Mar 30, 2026
Member
warm-coolguy
left a comment
warm-coolguy
left a comment
There was a problem hiding this comment.
Compared next to vue3/fix-memory-leak on Windows, Chrome. Ran npm run dev with both branches.
Testing sequence:
- Load snowbox, wait a little, take snapshot
- Add 20 clients, remove all clients
- Take snapshot
- GOTO 2
Repeated testing resulted in an additional 5MB snapshot size per loop. Growth behaviour was identical between branches. Didn't review the code since changes seem to be ineffective.
dopenguin
force-pushed
the
vue3/fix-memory-leak
branch
from
133c2d5 to
52b4515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some parts were not properly being cleaned up leading to an explosion in RAM usage after multiple additions and removals of an additional map in
snowbox. This, too, would be the case for any SPA that rerenders POLAR.Instructions for local reproduction and review
npm run snowboxhere and onnext. Check the Snapshot size difference after multiple additions and removals. It should be fairly less now.Note that there is still some overhead of about 100kb - 200kb per instance. I was not able to remove that and it may be an issue with
vuedirectly.