Skip to content

feat: update layer type documentation#556

Merged
dopenguin merged 2 commits intonextfrom
vue3/documentation-layer-type
Apr 17, 2026
Merged

feat: update layer type documentation#556
dopenguin merged 2 commits intonextfrom
vue3/documentation-layer-type

Conversation

@dopenguin
Copy link
Copy Markdown
Member

Summary

Allow layer type to be an arbitrary string so mask layers may be grouped freely.

Instructions for local reproduction and review

Check in iceberg if you now can set the type of a layer to any value.

@dopenguin dopenguin added this to the POLAR@3 milestone Feb 23, 2026
@dopenguin dopenguin added enhancement New feature or request refactor Refactoring of previous code labels Feb 23, 2026
@dopenguin dopenguin changed the title type: update layer type documentation feat: update layer type documentation Feb 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 23, 2026

PR Preview Action v1.8.0

QR code for preview link

🚀 View preview at
https://Dataport.github.io/polar/pr-preview/pr-556/

Built to branch gh-pages at 2026-04-17 10:03 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@dopenguin dopenguin self-assigned this Feb 23, 2026
@dopenguin dopenguin force-pushed the vue3/documentation-layer-type branch 5 times, most recently from 756f8aa to 2da8e25 Compare March 12, 2026 11:36
@dopenguin dopenguin force-pushed the vue3/documentation-layer-type branch from 2da8e25 to 4984970 Compare March 17, 2026 16:11
Copy link
Copy Markdown
Member

@warm-coolguy warm-coolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏓 @dopenguin

Documentation on how the appearing titles (currently dankTitle for custom type "dank") can be properly localized seems to be fitting as part of the LayerType documentation, as that would be my immediate follow-up question after trying the feature.

@dopenguin dopenguin force-pushed the vue3/documentation-layer-type branch from 4984970 to 7ec09f0 Compare March 30, 2026 10:53
@dopenguin dopenguin force-pushed the vue3/documentation-layer-type branch 2 times, most recently from c0681f3 to 58f97d8 Compare April 10, 2026 09:25
@dopenguin
Copy link
Copy Markdown
Member Author

🏓 @dopenguin

Documentation on how the appearing titles (currently dankTitle for custom type "dank") can be properly localized seems to be fitting as part of the LayerType documentation, as that would be my immediate follow-up question after trying the feature.

Added c0681f3

🏓 @warm-coolguy @oeninghe-dataport

@dopenguin dopenguin force-pushed the vue3/documentation-layer-type branch from 58f97d8 to 2d06707 Compare April 14, 2026 09:41
Copy link
Copy Markdown
Member

@warm-coolguy warm-coolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dopenguin dopenguin force-pushed the vue3/documentation-layer-type branch from 2d06707 to 7aaf444 Compare April 17, 2026 10:00
@dopenguin dopenguin merged commit cb5a9fc into next Apr 17, 2026
4 checks passed
@dopenguin dopenguin deleted the vue3/documentation-layer-type branch April 17, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Refactoring of previous code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants