feat(filter): migrate plugin by oeninghe-dataport · Pull Request #436 · Dataport/polar

oeninghe-dataport · 2026-01-02T12:20:20Z

Summary

The filter plugin is migrated to POLAR@3.

Instructions for local reproduction and review

Open snowbox.
Enable the layer "Anliegen (MML)" and move the map to Hamburg, Germany.
Use the filters and test them.

Additional hints

Layout flaws

The layout of the filter dialog is somehow broken.
It is larger than the map's height (in the snowbox).
You may scroll it, but you cannot see the bottom of the scrollbar, as it overflows.

This, however, is, as far as I can tell, not a filter-specific problem but located probably in iconMenu.
Therefore, it is not considered here.

Fixed with #493

Styling

The general styling for this component is inspired by some (deprecated) UI/UX drafts.

Date range picker

The date range picker consists of two browser-native date pickers.
This control is supported by all major browsers (https://caniuse.com/input-datetime).

This improvised date range picker already supports limiting the dates (up to or starting with today's date).
An advanced implementation (as before with Vuetify) is left open to another PR.

Relevant tickets, issues, et cetera

Closes #370

Bumps [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) from 20.2.0 to 20.3.0. - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v20.3.0/@commitlint/cli) --- updated-dependencies: - dependency-name: "@commitlint/cli" dependency-version: 20.3.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

# Conflicts: # package-lock.json # src/core/types/plugin.ts

github-actions · 2026-01-19T15:47:26Z

PR Preview Action v1.8.0
🚀 View preview at https://Dataport.github.io/polar/pr-preview/pr-436/
Built to branch `gh-pages` at 2026-04-15 15:23 UTC. Preview will be ready when the GitHub Pages deployment is complete.

dopenguin

I can't seem to be able to tab through the selection of the buttons. Please take a look at this. This probably results from the <input>s being hidden and only the labels being displayed. Not sure how a ScreenReader would interpret them as well. Maybe using an actual button here seems reasonable?
Selecting a BlockButton makes it jiggle a bit, which is annoying. This should be fixable by reserving some space for the border.
Implement the old UI for layout: 'nineRegions'. As we didn't have a final draft yet, the previous layout should be available.

I've also attached a patch which adds the pointer-events to the correct elements.

🏓 @oeninghe-dataport

oeninghe-dataport · 2026-02-20T09:25:42Z

Could you please add an example to iceberg?

b893b49

The filter in nineRegions should look like the previous UI, like I mentioned before. So please add the missing expansion panels.

Before:

Now:

Oh, right, I missed that one. Is changed with 9476c57

oeninghe-dataport · 2026-02-20T09:26:43Z

🏓 @dopenguin

dopenguin

Could you please add an example to iceberg?

b893b49

The filter in nineRegions should look like the previous UI, like I mentioned before. So please add the missing expansion panels.
Before:
Now:

Oh, right, I missed that one. Is changed with 9476c57

All the following things are related to the implementation in layout: 'nineRegions'.

There is some empty space on the right:

The window jiggles when hovering the date input:

The spacing for the date input looks off. As in: not enough space on top, too much on the bottom. Also, the <hr> looks off if no other accordion follows.

🏓 @oeninghe-dataport

dopenguin · 2026-02-23T17:46:10Z

+	/**
+	 * An icon that is assigned to the value for filtering.
+	 */
+	icon?: Icon


This can only be used in layout: 'standard', correct?

Correct. f2071ff

Linking to {@link MapConfiguration.layout | layout} should be the way here.

dopenguin · 2026-04-07T09:27:32Z

@oeninghe-dataport pls @ me once you've tackled all the things!

…ilter

oeninghe-dataport · 2026-04-13T10:33:58Z

All the following things are related to the implementation in layout: 'nineRegions'.

There is some empty space on the right:

This is caused by iconMenu (scrollbar-gutter: stable), and should therefore be handled as a separate issue.

The window jiggles when hovering the date input:

I cannot reproduce this any longer using @kern-ux/native@^2.5.0

oeninghe-dataport · 2026-04-13T10:50:16Z

The spacing for the date input looks off. As in: not enough space on top, too much on the bottom. Also, the <hr> looks off if no other accordion follows.

d8f619b

oeninghe-dataport · 2026-04-13T10:50:57Z

🏓 @dopenguin Your turn again :)

dopenguin · 2026-04-13T13:24:51Z

The spacing for the date input looks off. As in: not enough space on top, too much on the bottom. Also, the <hr> looks off if no other accordion follows.

d8f619b

The <hr> still looks off and was not there on the last expansion panel in the previous implementation

dopenguin

Please also mind #436 (comment)

🏓 @oeninghe-dataport

oeninghe-dataport · 2026-04-14T12:59:59Z

The spacing for the date input looks off. As in: not enough space on top, too much on the bottom. Also, the <hr> looks off if no other accordion follows.

d8f619b

The <hr> still looks off and was not there on the last expansion panel in the previous implementation

434dc05 should now match the previous implementation, although I prefer the KERN style here.

oeninghe-dataport · 2026-04-14T13:00:08Z

🏓 @dopenguin

dopenguin · 2026-04-14T14:17:26Z

The spacing for the date input looks off. As in: not enough space on top, too much on the bottom. Also, the <hr> looks off if no other accordion follows.

d8f619b

The <hr> still looks off and was not there on the last expansion panel in the previous implementation

434dc05 should now match the previous implementation, although I prefer the KERN style here.

This is certainly something that will be tackled when we tackle this with a new design.

You missed a spot #436 (comment)

The color for the title does not really seem to be a good choice :D

Please rebase the branch onto main please or merge main into this branch.

🏓 @oeninghe-dataport

…ilter

oeninghe-dataport · 2026-04-15T15:23:22Z

You missed a spot #436 (comment)

See there

The color for the title does not really seem to be a good choice :D

Yea, this is kinda hard to read even on usual screens. ecb39bf makes testing that easier, and 27e376f fixes it.

Please rebase the branch onto main please or merge main into this branch.

I hope that you wanted to say next. If so, 33adf62. If not...this will take some more time ;)

🏓 @oeninghe-dataport

🏓 @dopenguin

oeninghe-dataport added this to the POLAR@3 milestone Jan 2, 2026

oeninghe-dataport self-assigned this Jan 2, 2026

oeninghe-dataport added the refactor Refactoring of previous code label Jan 2, 2026

oeninghe-dataport linked an issue Jan 2, 2026 that may be closed by this pull request

Migration of Filter plugin to POLAR@3 #370

Open

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch from bd44e84 to 4640a4e Compare January 2, 2026 13:02

dependabot bot and others added 2 commits January 5, 2026 17:07

ci(iceberg): make tsc acknowledge vitest-caused node types

0328f14

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch from 4640a4e to 22cd58a Compare January 5, 2026 16:09

fix(core): enforce usage of Icon type

07048a5

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch 2 times, most recently from a9658ca to 9a5d3cf Compare January 7, 2026 15:33

feat(filter): migrate plugin

2fa72f1

oeninghe-dataport force-pushed the vue3/migrate-plugin-filter branch from 9a5d3cf to 2fa72f1 Compare January 7, 2026 15:38

oeninghe-dataport marked this pull request as ready for review January 7, 2026 15:45

oeninghe-dataport requested review from dopenguin and warm-coolguy as code owners January 7, 2026 15:45

oeninghe-dataport commented Jan 12, 2026

View reviewed changes

Comment thread src/plugins/filter/store.ts Outdated

dopenguin added 2 commits January 16, 2026 16:46

Merge branch 'next' into vue3/migrate-plugin-filter

6aabb56

# Conflicts: # package-lock.json # src/core/types/plugin.ts

fix(filter): use correct import for export store

cd23d05

dopenguin removed the request for review from warm-coolguy January 19, 2026 10:33

Merge branch 'next' into vue3/migrate-plugin-filter

56ea116

dopenguin added 2 commits January 20, 2026 11:27

Merge branch 'next' into vue3/migrate-plugin-filter

9c92633

Merge branch 'next' into vue3/migrate-plugin-filter

e6916db

dopenguin mentioned this pull request Jan 22, 2026

fix(iconMenu): adjust size of the StandardMenuList #493

Merged

oeninghe-dataport and others added 2 commits January 23, 2026 10:42

style: apply new linting rule for self-closing

25d11ec

Merge branch 'next' into vue3/migrate-plugin-filter

b7b6c3b

dopenguin requested changes Jan 23, 2026

View reviewed changes

dopenguin added 2 commits January 23, 2026 13:50

Merge branch 'next' into vue3/migrate-plugin-filter

0d1200c

Merge branch 'next' into vue3/migrate-plugin-filter

52c14f3

oeninghe-dataport added 2 commits February 20, 2026 10:18

fix(filter): use accordion for filter in nine-regions

9476c57

refactor(core): use dash as ID separator for radio group

efd4b66

Merge branch 'next' into vue3/migrate-plugin-filter

fff615e

dopenguin requested changes Feb 23, 2026

View reviewed changes

dopenguin reviewed Feb 23, 2026

View reviewed changes

Comment thread src/plugins/filter/components/FilterCategory.ce.vue Outdated

dopenguin reviewed Feb 23, 2026

View reviewed changes

dopenguin and others added 4 commits February 23, 2026 19:56

Merge branch 'next' into vue3/migrate-plugin-filter

f6e7ebd

docs(filter): add hint that icon is standard-specific

f2071ff

Merge branch 'next' into vue3/migrate-plugin-filter

5cbfa00

Merge branch 'next' into vue3/migrate-plugin-filter

a8fbc28

oeninghe-dataport added 2 commits April 13, 2026 10:46

refactor(filter): add separate store for categories

0685298

Merge remote-tracking branch 'origin/next' into vue3/migrate-plugin-f…

a634a5b

…ilter

fix(filter): improve spacing for nine-regions layout

d8f619b

dopenguin requested changes Apr 13, 2026

View reviewed changes

Comment thread src/plugins/filter/stores/category.ts

fix(filter): adapt border style for accordion to match old behavior

434dc05

oeninghe-dataport added 4 commits April 15, 2026 16:33

docs(filter): use typedoc-linking for layout reference

dc886e8

Merge remote-tracking branch 'origin/next' into vue3/migrate-plugin-f…

33adf62

…ilter

test(iceberg): add color scheme switch

ecb39bf

fix(filter): use color-scheme-considering value for section title

27e376f

Conversation

oeninghe-dataport commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Instructions for local reproduction and review

Additional hints

Layout flaws

Styling

Date range picker

Relevant tickets, issues, et cetera

Uh oh!

Uh oh!

github-actions bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Built to branch gh-pages at 2026-04-15 15:23 UTC. Preview will be ready when the GitHub Pages deployment is complete.

Uh oh!

dopenguin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oeninghe-dataport commented Feb 20, 2026

Uh oh!

oeninghe-dataport commented Feb 20, 2026

Uh oh!

dopenguin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dopenguin Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

oeninghe-dataport Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

dopenguin Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oeninghe-dataport Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

dopenguin commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oeninghe-dataport commented Apr 13, 2026

Uh oh!

oeninghe-dataport commented Apr 13, 2026

Uh oh!

oeninghe-dataport commented Apr 13, 2026

Uh oh!

dopenguin commented Apr 13, 2026

Uh oh!

dopenguin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oeninghe-dataport commented Apr 14, 2026

Uh oh!

oeninghe-dataport commented Apr 14, 2026

Uh oh!

dopenguin commented Apr 14, 2026

Uh oh!

oeninghe-dataport commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

oeninghe-dataport commented Jan 2, 2026 •

edited

Loading

github-actions bot commented Jan 19, 2026 •

edited

Loading

Built to branch `gh-pages` at 2026-04-15 15:23 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

dopenguin left a comment •

edited

Loading

dopenguin Apr 13, 2026 •

edited

Loading

dopenguin commented Apr 7, 2026 •

edited

Loading

oeninghe-dataport commented Apr 15, 2026 •

edited

Loading