[datadog-operator] Expose DCA Agent Sidecar TLS Config#2700
Open
[datadog-operator] Expose DCA Agent Sidecar TLS Config#2700
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
==========================================
- Coverage 38.81% 38.77% -0.04%
==========================================
Files 307 307
Lines 26610 26635 +25
==========================================
Hits 10329 10329
- Misses 15501 15522 +21
- Partials 780 784 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
6 tasks
Contributor
|
For documentation styleguide reasons, can we capitalize |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expose config option + creates RBACs for creating and mounting the cluster agent's certificate onto agent sidecar container it creates in application namespaces.
Motivation
Expose config option for new Agent feature for TLS communication on agent sidecar in admission controller
Minimum Agent Versions
This feature works only with newer Agent versions. However, the configmap rbac is fine to be applied everywhere.
Describe your test plan
Apply the following agent crd config
Check that the configmaps rbacs are present on the dca role
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel