Set x-keep-typed-in-additional-properties on UsageSummary schemas#1760
Merged
api-clients-generation-pipeline[bot] merged 4 commits intoJun 16, 2026
Merged
Conversation
api-clients-generation-pipeline
Bot
requested a review
from a team
as a code owner
api-clients-generation-pipeline
Bot
requested a review
from a team
as a code owner
nogates
approved these changes
Jun 16, 2026
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
2 times, most recently
from
9ca8ce5 to
55b68ac
Compare
When a schema sets `x-keep-typed-in-additional-properties: true`, pre-insert every key into `additional_properties` before the match dispatch so typed and untyped fields are both accessible from a single map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rde_json::Value Add inline comment explaining that deserializing into serde_json::Value always succeeds, so the Ok branch always fires. The guard future-proofs against typed additionalProperties schemas where the conversion could fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…comment "future-proofs" implied graceful handling; the comment now accurately notes that a type mismatch silently drops the entry, same as the catch-all arm. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
from
55b68ac to
d07a1cc
Compare
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
from
d07a1cc to
0d2a65f
Compare
api-clients-generation-pipeline
Bot
deleted the
datadog-api-spec/generated/5941
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#5941 Test branch datadog-api-spec/test/czhang/usage-summary-typed-in-additional-properties