Set x-keep-typed-in-additional-properties on UsageSummary schemas#1759
Closed
api-clients-generation-pipeline[bot] wants to merge 4 commits into
Closed
Set x-keep-typed-in-additional-properties on UsageSummary schemas#1759api-clients-generation-pipeline[bot] wants to merge 4 commits into
api-clients-generation-pipeline[bot] wants to merge 4 commits into
Conversation
When a schema sets `x-keep-typed-in-additional-properties: true`, pre-insert every key into `additional_properties` before the match dispatch so typed and untyped fields are both accessible from a single map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rde_json::Value Add inline comment explaining that deserializing into serde_json::Value always succeeds, so the Ok branch always fires. The guard future-proofs against typed additionalProperties schemas where the conversion could fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…comment "future-proofs" implied graceful handling; the comment now accurately notes that a type mismatch silently drops the entry, same as the catch-all arm. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#5941 Test branch datadog-api-spec/test/czhang/usage-summary-typed-in-additional-properties