Set x-keep-typed-in-additional-properties on UsageSummary schemas#3493
Merged
api-clients-generation-pipeline[bot] merged 3 commits intoJun 16, 2026
Merged
Conversation
api-clients-generation-pipeline
Bot
requested a review
from a team
as a code owner
api-clients-generation-pipeline
Bot
requested a review
from a team
as a code owner
nogates
approved these changes
Jun 16, 2026
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
2 times, most recently
from
8adee03 to
29eb115
Compare
When a schema sets `x-keep-typed-in-additional-properties: true`, also add typed property keys to `additional_properties` so all fields are accessible from a single map regardless of when they were added to the spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… before The previous approach stored the raw pre-coercion hash value. After setters run, self.attr_name holds the coerced value. We now copy post-coercion so both access paths return consistent types. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
from
29eb115 to
746982a
Compare
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
from
746982a to
146ba45
Compare
api-clients-generation-pipeline
Bot
deleted the
datadog-api-spec/generated/5941
branch
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
) * Support x-keep-typed-in-additional-properties in Ruby model generator When a schema sets `x-keep-typed-in-additional-properties: true`, also add typed property keys to `additional_properties` so all fields are accessible from a single map regardless of when they were added to the spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: copy typed fields into additional_properties after coercion, not before The previous approach stored the raw pre-coercion hash value. After setters run, self.attr_name holds the coerced value. We now copy post-coercion so both access paths return consistent types. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Regenerate client from commit 3677df7 of spec repo --------- Co-authored-by: Charlie Zhang <charlie.zhang@datadoghq.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> c8385e3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#5941 Test branch datadog-api-spec/test/czhang/usage-summary-typed-in-additional-properties