Set x-keep-typed-in-additional-properties on UsageSummary schemas#3492
Closed
api-clients-generation-pipeline[bot] wants to merge 3 commits into
Closed
Set x-keep-typed-in-additional-properties on UsageSummary schemas#3492api-clients-generation-pipeline[bot] wants to merge 3 commits into
api-clients-generation-pipeline[bot] wants to merge 3 commits into
Conversation
When a schema sets `x-keep-typed-in-additional-properties: true`, also add typed property keys to `additional_properties` so all fields are accessible from a single map regardless of when they were added to the spec. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… before The previous approach stored the raw pre-coercion hash value. After setters run, self.attr_name holds the coerced value. We now copy post-coercion so both access paths return consistent types. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
api-clients-generation-pipeline
Bot
requested a review
from a team
as a code owner
api-clients-generation-pipeline
Bot
requested a review
from a team
as a code owner
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 8763d9b | Docs | Datadog PR Page | Give us feedback! |
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
from
a8484f0 to
8763d9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#5941 Test branch datadog-api-spec/test/czhang/usage-summary-typed-in-additional-properties