Set x-keep-typed-in-additional-properties on UsageSummary schemas#3693
Merged
api-clients-generation-pipeline[bot] merged 3 commits intoJun 16, 2026
Merged
Conversation
nogates
approved these changes
Jun 16, 2026
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
2 times, most recently
from
fb728f1 to
4310c66
Compare
When a schema sets `x-keep-typed-in-additional-properties: true`, emit a `_keep_typed_in_additional_properties = True` class attribute. In Python all fields are already stored in `_data_store` and accessible via `model["key"]` regardless of type; this marker makes the intent explicit for tooling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…mantic marker In Python, typed fields are already reachable via bracket notation through _data_store, so no runtime behaviour change is required. The marker makes the flag visible for introspection and aligns semantics with other language SDKs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
from
4310c66 to
9e76030
Compare
api-clients-generation-pipeline
Bot
force-pushed
the
datadog-api-spec/generated/5941
branch
from
9e76030 to
fad51bf
Compare
api-clients-generation-pipeline
Bot
deleted the
datadog-api-spec/generated/5941
branch
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
) * Support x-keep-typed-in-additional-properties in Python model generator When a schema sets `x-keep-typed-in-additional-properties: true`, emit a `_keep_typed_in_additional_properties = True` class attribute. In Python all fields are already stored in `_data_store` and accessible via `model["key"]` regardless of type; this marker makes the intent explicit for tooling. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: annotate _keep_typed_in_additional_properties as a cross-SDK semantic marker In Python, typed fields are already reachable via bracket notation through _data_store, so no runtime behaviour change is required. The marker makes the flag visible for introspection and aligns semantics with other language SDKs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Regenerate client from commit 3677df7 of spec repo --------- Co-authored-by: Charlie Zhang <charlie.zhang@datadoghq.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 94cca5a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#5941 Test branch datadog-api-spec/test/czhang/usage-summary-typed-in-additional-properties