Fix consecutive-acronym handling in generated examples and apis/__init__.py - #3454
Open
pdv wants to merge 2 commits into
Open
Fix consecutive-acronym handling in generated examples and apis/__init__.py#3454pdv wants to merge 2 commits into
pdv wants to merge 2 commits into
Conversation
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken imports in generated examples and
apis/__init__.pywhen an OpenAPI tag contains consecutive acronyms (e.g.Bits AI SRE).The library files themselves (
bits_ai_sre_api.py) generate correctly becausecli.pysnake_cases the raw tag. But two places worked from a spaceless PascalCase form (BitsAISRE/BitsAISREApi) and re-snake_cased that, which producedbits_aisre_api.Changes:
templates/apis.j2: snake_case the raw tag (loop variableapi) instead of the class name.templates/example.j2: import fromraw_tag|safe_snake_caseinstead ofname|safe_snake_case..generator/conftest.py: stash the raw tag incontext["api_instance"]so templates can use it.Behavior is unchanged for any tag without consecutive acronyms.
Test plan
./generate.shlocally with "Bits AI SRE" tagLinks