Increased LED limit that the Arduino can support#439
Open
Fiveol wants to merge 1 commit intoDarthAffe:masterfrom
Open
Increased LED limit that the Arduino can support#439Fiveol wants to merge 1 commit intoDarthAffe:masterfrom
Fiveol wants to merge 1 commit intoDarthAffe:masterfrom
Conversation
Used a 16-bit integer instead of an 8-bit integer to increase the led limit from 255 to 65535
Owner
|
since this breaks existing devices I'm quite oposed to this change. What is the justification behind this? (Is there a real usecase?) From my tests back when I implemented a basic arduino way way to slow to drive that amount of leds. Aside from that the latency of the led-strip itself would be really bad so it's advisable to split them anyway. |
Author
|
It would make it possible to drive my 50 ft 1000 led strip. My Arduino Uno can handle it, especially with the custom baud rate feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used a 16-bit integer instead of an 8-bit integer to increase the led limit from 255 to 65535